Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winging it 10 #677

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Winging it 10 #677

merged 6 commits into from
Aug 13, 2024

Conversation

SondraE
Copy link
Contributor

@SondraE SondraE commented Aug 1, 2024

Related Issue(s)

#676

Steps to test/reproduce

posts list
/2024/07/23/winging-it-10/

Copy link

github-actions bot commented Aug 1, 2024

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..wingingit10

@SondraE SondraE linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just some cleanup in the summary.

content/blog/wingingit/winging-it-10.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-10.md Outdated Show resolved Hide resolved
SondraE and others added 2 commits August 2, 2024 10:29
Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
@jgerigmeyer jgerigmeyer self-requested a review August 5, 2024 14:33
Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but had one typo, and then I offered some suggestions.

content/blog/wingingit/winging-it-10.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-10.md Outdated Show resolved Hide resolved
- youtube: aDMWD_CYpEI
summary: |
We talk with Stephanie Eckles
– the brain behind ModernCSS.dev and SmolCSS.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we should link these, but if we can't/shouldn't then at minimum the address is SmolCSS.dev (not .css). I'll check to see if the YouTube description has this same typo?

Suggested change
– the brain behind ModernCSS.dev and SmolCSS.css
– the brain behind [ModernCSS.dev](https://moderncss.dev/) and [SmolCSS.dev](https://smolcss.dev/)

SondraE and others added 3 commits August 7, 2024 09:20
Co-authored-by: Stacy Kvernmo <stacyk@users.noreply.github.com>
Co-authored-by: Stacy Kvernmo <stacyk@users.noreply.github.com>
@SondraE
Copy link
Contributor Author

SondraE commented Aug 13, 2024

@stacyk @mirisuzanne I've addressed all your comments. This has the same video thumbnail issue as the other videos. I assume that should not hold up this PR, right?

Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SondraE SondraE merged commit 3a306d0 into main Aug 13, 2024
10 checks passed
@SondraE SondraE deleted the wingingit10 branch August 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Winging It Ep 10 to OddSite
4 participants