-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winging it 10 #677
Winging it 10 #677
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..wingingit10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just some cleanup in the summary.
Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but had one typo, and then I offered some suggestions.
- youtube: aDMWD_CYpEI | ||
summary: | | ||
We talk with Stephanie Eckles | ||
– the brain behind ModernCSS.dev and SmolCSS.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like we should link these, but if we can't/shouldn't then at minimum the address is SmolCSS.dev (not .css). I'll check to see if the YouTube description has this same typo?
– the brain behind ModernCSS.dev and SmolCSS.css | |
– the brain behind [ModernCSS.dev](https://moderncss.dev/) and [SmolCSS.dev](https://smolcss.dev/) |
Co-authored-by: Stacy Kvernmo <stacyk@users.noreply.github.com>
Co-authored-by: Stacy Kvernmo <stacyk@users.noreply.github.com>
@stacyk @mirisuzanne I've addressed all your comments. This has the same video thumbnail issue as the other videos. I assume that should not hold up this PR, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Related Issue(s)
#676
Steps to test/reproduce
posts list
/2024/07/23/winging-it-10/