-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple matching blocks #243
Conversation
Hi @codr thanks for contributing! Can you provide some background on the use-case here, since it's not a feature that's been discussed? It would also be great to have updates to the changelog and documentation, so that people know about this new functionality, and how to use it. |
Hello, Thanks for the replay. The use-case is: when testing Sass with multiple block with matching selectors, only the first block can be accounted for. |
update test to make sure it checks the second block
Add support for `contians` when multiple matching selectors exists
- Update changelog message - ran `yarn commit`
Makes sense to me!
The only potential edge-case I can think of (but may not be an issue) is if it's possible to have accidental bleed across multiple tests that use the same selector? I'm not as familiar with the JS parsing step here, so maybe @jgerigmeyer can speak to that. Otherwise, it looks good to me. Thanks again! (We may want to document this in either the readme or the |
I'm happy to add some documentation. I'm not entirely sure where or what. Looking at this mixing comment, I think this was the original intent. Maybe this is more of a bug fix than a feature? |
Oh yeah, that seems fair. Maybe we can leave the documentation as-is. |
@codr Thanks! 🚀 |
No description provided.