Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix returntype and docs for getApplicationId #49

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix returntype and docs for getApplicationId #49

merged 1 commit into from
Aug 25, 2020

Conversation

fstof
Copy link

@fstof fstof commented Aug 19, 2020

fixes #48

@fstof fstof changed the base branch from master to develop August 19, 2020 14:22
@fstof fstof changed the base branch from develop to master August 19, 2020 21:42
@fstof
Copy link
Author

fstof commented Aug 19, 2020

Not sure if PR should be to develop or to master branch

@DennisAlund DennisAlund self-requested a review August 25, 2020 07:47
@DennisAlund
Copy link
Member

DennisAlund commented Aug 25, 2020 •
edited
Loading

Thank you for your contribution, please bump the patch version from 0.6.0 to 0.6.1 and write a release note in CHANGELOG.md

flutter_facebook_app_events/pubspec.yaml

Line 4 in 48669e2

version: 0.6.0

DennisAlund
DennisAlund requested changes Aug 25, 2020
View reviewed changes
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating the version number in pubspec.yaml and making release notes. Please check which current version is on master and update patch version accordingly.

@DennisAlund DennisAlund changed the base branch from master to develop August 25, 2020 08:01
@DennisAlund
Copy link
Member

I'm changing the base branch and updating the pubspec.yaml myself. Thank you for your contributions 🙏

@DennisAlund DennisAlund merged commit 9a4c343 into oddbit:develop Aug 25, 2020
@DennisAlund DennisAlund mentioned this pull request Aug 25, 2020
Closed
@fstof
Copy link
Author

fstof commented Aug 30, 2020

sorry for not updating man, been a hectic week on my side.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisAlund DennisAlund DennisAlund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getApplicationId not returning String
2 participants
@fstof @DennisAlund