Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Divide 'Multiarray.hpp' into several headers. #107

Merged
merged 12 commits into from
Sep 25, 2014

Conversation

oddkiva
Copy link
Owner

@oddkiva oddkiva commented Sep 25, 2014

As the title says, we divide the header 'MultiArray.hpp' into several header files:

  • 'ElementTraits.hpp'
  • 'MultiArray.hpp'

In the wake of this PR, we also did the following:

  • Raise a runtime exception when using the assignment operator to wrapped data instead of exiting the program.
  • Add unit test for that.
  • Add missing copyright notices to some recently added files.

@oddkiva
Copy link
Owner Author

oddkiva commented Sep 25, 2014

It seems there is room for improvement regarding the assignment operator of the 'MultiArray' class (cf. issue #108).

@oddkiva
Copy link
Owner Author

oddkiva commented Sep 25, 2014

Travis is happy. Merging.

oddkiva pushed a commit that referenced this pull request Sep 25, 2014
[MAINT] Divide 'Multiarray.hpp' into several headers.
@oddkiva oddkiva merged commit 6e5edbb into develop Sep 25, 2014
@oddkiva oddkiva deleted the maint-fix-break-down-multiarray-hpp branch September 25, 2014 21:19
@oddkiva oddkiva self-assigned this Oct 1, 2014
@oddkiva oddkiva removed their assignment Aug 24, 2015
@oddkiva oddkiva modified the milestone: 1.1 Aug 24, 2015
@oddkiva oddkiva self-assigned this Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant