[MAINT] Fix image processing module. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not an important feature and the support of this is way too clunky.
…into fix-image-processing-module Conflicts: src/DO/ImageProcessing/Deriche.hpp
This is not a particularly fast but it can be optimized later for particular cases in 2D.
|
Let's do the rest in other PRs... |
| Vectord x( r->template cast<double>().cwiseProduct(f) ); | ||
| convertColor(nI(*r), interpolate(I, x)); | ||
| Vectord x( r.position().template cast<double>().cwiseProduct(f) ); | ||
| convertColor(*r, interpolate(I, x)); | ||
| } | ||
| return nI; | ||
| } |
There was a problem hiding this comment.
Modifications in these files are partly obsolete since there were done a long time ago. So check these very thoroughly.
| @@ -226,7 +228,8 @@ namespace DO { | |||
|
|
|||
| inline void operator()(HessianMatrix& H, const Coords& p) const | |||
| { | |||
| ScalarIterator loc(scalar_field_.begin_range(p)); | |||
| ScalarIterator loc(scalar_field_.begin_range()); | |||
| loc += p; | |||
| operator()(H, loc); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Modifications in these files are partly obsolete since there were done a long time ago. So check these very thoroughly.
|
Let's not delay this PR otherwise the review is going to be hard. With the newly added unit tests, the |
|
Travis is happy. Merging. |
oddkiva
pushed a commit
that referenced
this pull request
Sep 29, 2014
[MAINT] Fix image processing module.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for each submodules and fix everywhere if necessary:
[ ] Linear filtering[ ] DifferentialLet's not do everything at once and break down this boring maintenance task into smaller PRs.