fix: Move EntityMoveProcessor to portals module, only check entities in worlds with activated portals #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in worlds with activated portals EntityMoveProcessor can be quite expensive and is only used for portals. Moving it to the portals module means the performance cost is only paid for servers that use portals. There's also no need to check for movement of all entities when no portals are activated - instead, only check entities in worlds with active portals.
|
Thanks a lot, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityMoveProcessor can be quite expensive and is only used for portals. Moving it to the portals module means the performance cost is only paid for servers that use portals. There's also no need to check for movement of all entities when no portals are activated - instead, only check entities in worlds with active portals.