Fix issue with capabilities component #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icidasset
commented
Jun 12, 2023
| app ? [ [ "appFolder", `${app.creator}/${app.name}` ] ] : [], | ||
| fs?.private ? fs.private.map(p => [ "privatePath", Path.toPosix(p, { absolute: true }) ]) : [], | ||
| fs?.public ? fs.public.map(p => [ "publicPath", Path.toPosix(p, { absolute: true }) ]) : [], | ||
| raw ? [ [ "raw", Base64.urlEncode(JSON.stringify(raw)) ] ] : [], |
There was a problem hiding this comment.
Really need to add a commit hook with some default formatting 😅 I switched editors.
There was a problem hiding this comment.
Yeah, that particular formatting comes up fairly often. Agreed a hook would be nice for it. 💯
bgins
approved these changes
Jun 12, 2023
| app ? [ [ "appFolder", `${app.creator}/${app.name}` ] ] : [], | ||
| fs?.private ? fs.private.map(p => [ "privatePath", Path.toPosix(p, { absolute: true }) ]) : [], | ||
| fs?.public ? fs.public.map(p => [ "publicPath", Path.toPosix(p, { absolute: true }) ]) : [], | ||
| raw ? [ [ "raw", Base64.urlEncode(JSON.stringify(raw)) ] ] : [], |
There was a problem hiding this comment.
Yeah, that particular formatting comes up fairly often. Agreed a hook would be nice for it. 💯
| @@ -202,7 +188,7 @@ async function getClassifiedViaPostMessage( | |||
| } | |||
|
|
|||
| const message = { | |||
| odd: "exchange-secrets", | |||
| webnative: "exchange-secrets", | |||
There was a problem hiding this comment.
Should we update the lobby to expect odd instead of webnative?
There was a problem hiding this comment.
Yeah, I'll make it so that it supports both 👍
| ]) | ||
| return new Promise((resolve, reject) => { | ||
| if (options.tries > 0) { | ||
| const unoMas = () => { |
There was a problem hiding this comment.
Claro que si. Uno mas esta bien. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it didn't work after all when changing the message passed to
postMessage🙈 Also got rid of thevia-postmessagecheck which added support for the old lobby which has long been deprecated for a while, and improved the retry function which wasn't working well (actually ran the action 20 times even though initial one succeeded).