RFC: Shapeit5 docker #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven-Thorsten Dietrich <sxd1425@miami.edu>
- the make files are identical after removing redundant declarations - use an include to import the common declarations - any subsequent overrides to the common declarations can be made in the module-specific makefiles below the include statement - this eliminates maintenance of around 600 lines of duplicate code without compromise in functionality Signed-off-by: Sven-Thorsten Dietrich <sxd1425@miami.edu>
Signed-off-by: Sven-Thorsten Dietrich <sxd1425@miami.edu>
thebigcorporation
force-pushed
the
shapeit5_docker
branch
from
c34a705
to
6a13534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a native docker build, that works out of the box.
While this branch can be merged into main, it depends on, is based on, and includes the changes in:
#77