-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin tornado version to <5 #25
Conversation
Torndao 5 changes thread/ioloop model and hangs unit tests, so fix version in requirements file to <5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests completed. Version of tornado installed was less than 5.
@ajgdls Thanks for testing. Related Q: excalibur-detector/control has this repo tag 0.2 during setup script so fails its own tests due to the tornado issue above. Possible fixes are for it to re-tag (.e.g 0.4.0 - but I know you recently tagged 0.3.0), decouple excalibur-detector/control from a specific release so it checks out head, or have a 'soft' tag that we move as necessary. Thoughts? |
Hi @timcnicholls I don't mind if you think we should make new releases. The modules have all now been released for DLS and so there is no issue with making new commits/releases. Another release of excalibur-detector will be made at DLS soon enough I'm sure. |
@ajgdls OK thanks, I'll merge the PR and tag 0.3.1. |
This PR pins the requirement for tornado to <5, to avoid issues with installation and hanging test runs. Also minor modifications to some tests to complete coverage of recent access logging changes.