Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tornado version to <5 #25

Merged
merged 6 commits into from
Jul 3, 2018
Merged

Pin tornado version to <5 #25

merged 6 commits into from
Jul 3, 2018

Conversation

timcnicholls
Copy link
Collaborator

This PR pins the requirement for tornado to <5, to avoid issues with installation and hanging test runs. Also minor modifications to some tests to complete coverage of recent access logging changes.

@timcnicholls timcnicholls requested a review from ajgdls July 3, 2018 09:22
@ghost ghost assigned timcnicholls Jul 3, 2018
@ghost ghost added the in progress label Jul 3, 2018
Copy link
Contributor

@ajgdls ajgdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests completed. Version of tornado installed was less than 5.

@timcnicholls
Copy link
Collaborator Author

@ajgdls Thanks for testing. Related Q: excalibur-detector/control has this repo tag 0.2 during setup script so fails its own tests due to the tornado issue above. Possible fixes are for it to re-tag (.e.g 0.4.0 - but I know you recently tagged 0.3.0), decouple excalibur-detector/control from a specific release so it checks out head, or have a 'soft' tag that we move as necessary. Thoughts?

@ajgdls
Copy link
Contributor

ajgdls commented Jul 3, 2018

Hi @timcnicholls I don't mind if you think we should make new releases. The modules have all now been released for DLS and so there is no issue with making new commits/releases. Another release of excalibur-detector will be made at DLS soon enough I'm sure.
We could make it 0.3.1 if we think it is minor?

@timcnicholls
Copy link
Collaborator Author

@ajgdls OK thanks, I'll merge the PR and tag 0.3.1.

@timcnicholls timcnicholls merged commit 7f8e96c into master Jul 3, 2018
@ghost ghost removed the in progress label Jul 3, 2018
@timcnicholls timcnicholls deleted the pin-tornado-version branch July 3, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants