Mutable tree #45
Mutable tree #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1087 1106 +19
=========================================
+ Hits 1087 1106 +19
Continue to review full report at Codecov.
|
| if isinstance(subtree, dict): | ||
| subtree = subtree[level] | ||
| else: | ||
| subtree = subtree[int(level)] |
There was a problem hiding this comment.
Could you just explain this part a little to me? You traverse down the tree and assume if the subtree isn't a dict then the next path level is always going to be an integer, is my understanding right?
There was a problem hiding this comment.
Pretty much, yeah. This was based off the traversal stuff in the set method, which does the same thing. The idea being that, if you're still traversing the path you set, you're either:
at a branch node of the tree, thus the next part should be another dict
at a node that contains a list, thus the next part of the path should be the list index
Then, obviously, if its neither of these things, you're path is invalid and it raises the ParameterTreeError
There was a problem hiding this comment.
I think some comments dotted throughout the code explaining these details at each step would be useful
…ble tree. Does not work the other way around, this may have to remain as a limitation
…ed tests and modified the recursive merge method to now allow this
Created a Mutable Flag for Parameter Tree. Setting this flag allows the creation and deletion of nodes in the parameter tree. This includes branch nodes and leaf nodes. Care should be taken when using a Mutable Parameter Tree to avoid overwriting Accessors and other nodes accidentally.
This change also removed the (long depreciated) Callback system from Parameter Tree