Table id drop down, multiple table selection and new Tabs #62
Conversation
|
Can one of the admins verify this patch? Also need an authorization to run tests. |
|
runtests |
…a of selected table ids
…selected table ids area
…s used to change the table id for every download.
|
Sir I have Implemented changes to download multiple table at once. Download button would work now to download multiple table ids at once. The Download options section currently selects options which are common for all table ids. I will push changes for it to enable selection of options for every table id. |
Shubhamr837
changed the title
|
runtests |
|
@Shubhamr837 Support for different options for each table can go in a separate pull request. |
|
Ok @linl33 I will create another pull request for that. |
There was a problem hiding this comment.
Let me know if you have questions. Please also prepare a pull request to update the docs (https://github.com/odk-x/docs).
src/main/java/org/opendatakit/suitcase/net/AttachmentManager.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| } | ||
| selectedTablesListPanel.updateSize(selectedTableIds.size()); // update the height of the JPanel to fit inside JScrollPane |
There was a problem hiding this comment.
Since the panel is inside a JScrollPane you shouldn't need to manually manage this panel's size.
There was a problem hiding this comment.
I tried it before but I don't know why the panel wasn't increasing its size vertically. I tried FlowLayout.CENTER and FlowLayout.LEADING also but its size was always increasing horizontally. On setting a size in the constructor its was adding elements to the new row but still its height was not changing once elements begun to overflow vertically. Thats why I implemented this method. If I find any alternative layout with a more simple implementation I would change it.
src/main/java/org/opendatakit/suitcase/ui/SelectedTablesListPanel.java
Outdated
Show resolved
Hide resolved
Shubhamr837
changed the title
Result integer is stored in a variable to check the return code.
Handle Error when response code is not 200
|
@linl33 @codeknight3 We are getting close to doing a release and I would like to include @Shubhamr837 changes. Therefore it would be very helpful if you could review this PR. |
|
@wbrunette I have Identified few bugs. One was corrected yesterday and other bugs I will try to correct today. |
|
@Shubhamr837. End of the week is fine. |
Correct bugs in delete and reset task.
|
@wbrunette I have made the corrections and corrected the bugs in delete and reset task. |
whats included in this PR?
Changed the title of the application.
Added drop down for table id.
IoPanel variable in main panel is made accessible by a public method to add pull panel as a property change listener to login task.