Issue 87 conebeam #178
Issue 87 conebeam #178
Conversation
| data : `DiscreteLp` | ||
| name : `str` | ||
| """ | ||
| path = pth.join(pth.join(pth.dirname(pth.abspath(__file__)), 'data'), |
There was a problem hiding this comment.
Saving to file is not a "simple" example. How about simply using vector.show()?
There was a problem hiding this comment.
Also, if saving to file, at least add those files to .gitignore.
There was a problem hiding this comment.
There is still the issue with the blocking when using an interactive backend which is slightly annoying when you create several figure. At the moment I'm also using these examples to check if the forward and back projections do work as expected which is more convenient when the images are saved. Once we have smarter test to check this we can remove the save statement. But for sure, I should have added these files to .gitignore.
There was a problem hiding this comment.
Then we need to fix the show issue, and if you need to do "temporary" things like this, save to some temporary folder outside of ODL. Then we dont get to many entries in gitignore.
Adding these requires mostly a utility to create the real counterpart of a complex space with corresponding real data type. This is implemented in the real_space and complex_space utils in odl.util.utility. Further changes: - Get data types from numpy in base_ntuples.py instead of manually entering them into the type maps - Accept an FnWeightingBase as weight argument in the initializers of Fn and CudaFn. That makes it easy to create a new space with the same weighting. - move fast_1d_tensor_mult to numerics.py in odl.util - remove some obsolete TODO comments in test files
This reverts commit 12c9c70.
This reverts commit 22c21d7.
kohr-h
force-pushed
the
issue-87__conebeam
branch
from
19cbe33
to
a6af045
Compare
|
Okay, waiting for the tests, then I'll merge. I'm going to write up the follow-up issues. |
ENH: Add geometries for tomography.
The ASTRA wrapper functions and related geometries are implemented. Tests and builds are working. However, there are inconsistencies within the geometry module. On the one hand because cone beam geometries are now using the ASTRA convention regarding the initial orientation of source and detector. (This was a quick fix to get ASTRA running with the helical cone beam geometry). On the other because the geometry class functions for the detector rotation, the source position, the detector position, the detector to source vector, etc are not working properly and/or need to be modified for rotations about arbitrary axes.
TODO
detectordoes not have tests)as_midp=Falseoption inuniform_samplingonce periodic discretizations are availablesurface_derivaxisproperty to define the direction of rotation Direction of rotation #205