[FIX] test_themes: adapt switcher tooltip format #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brboi
force-pushed
the
master-web-unify-dropdown
branch
from
a03015e
to
20f41c7
Compare
This adapts the WebsiteSwitcherSystray's DropdownItem tooltips dataset to the changed API brought in the community repository. Task: 3266145
brboi
force-pushed
the
master-web-unify-dropdown
branch
from
20f41c7
to
32d28bf
Compare
brboi
changed the title
|
I'm sorry, @aab-odoo. I'm afraid I can't do that. |
|
@robodoo delegate=aab-odoo |
|
robodoo r+ |
robodoo
added a commit
to odoo/odoo
that referenced
this pull request
Feb 7, 2024
We currently have too many different implementation of the same concern: an input with a dropdown/popover/select menu that can be customized, display a list of elements, let the user navigate with the keyboard, can be closed with escape, can be closed with an outside click. Also, the current navigation systems does not handle inputs properly. This commit addresses that by doing multiple things: - It tries to improve the Dropdown component with a cleaner props API while keeping its ease of use. - The navigation has been improved to support inputs and better customization. - The Dropdown now uses the popover/overlay service which will cause less z-index issues. closes #137691 Related: odoo/design-themes#765 Related: odoo/enterprise#48452 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 7, 2024
This adapts the WebsiteSwitcherSystray's DropdownItem tooltips dataset to the changed API brought in the community repository. closes #765 Task: 3266145 Related: odoo/enterprise#48452 Related: odoo/odoo#137691 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
xlu-odoo
pushed a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 21, 2024
This adapts the WebsiteSwitcherSystray's DropdownItem tooltips dataset to the changed API brought in the community repository. closes odoo#765 Task: 3266145 Related: odoo/enterprise#48452 Related: odoo/odoo#137691 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the WebsiteSwitcherSystray's DropdownItem
tooltips dataset to the changed API brought in
the community repository.
Task: 3266145