[IMP] spreadsheet: remove default templates #11832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
auva-odoo
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Hello @mcsi-odoo great job on this PR! I added a few comments and suggestions; feel free to contact me if something isn't clear and we'll discuss it!
mcsi-odoo
commented
Jan 30, 2025
mcsi-odoo
force-pushed
the
saas-17.4-spreadsheet-templates
branch
from
e15c15b to
8f2453e
Compare
auva-odoo
requested changes
Jan 31, 2025
There was a problem hiding this comment.
A few minor suggestions @mcsi-odoo (feel free to reach out if there's anything you'd like to discuss!) but otherwise this looks very good to me 🙂 Thank you!
task-4278043
mcsi-odoo
force-pushed
the
saas-17.4-spreadsheet-templates
branch
from
8f2453e to
afdf893
Compare
auva-odoo
approved these changes
Jan 31, 2025
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2025
task-4278043 closes #11832 Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2025
task-4278043 closes #11832 Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-4278043