-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[IMP] howtos/website_themes: Rework of the "Going live" page #12225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6875bbc
to
e8bc918
Compare
Hi @bram-odoo , as discussed with @AntoineVDV here, we should update the anchors structure following a Make sure you update your other PRs accordingly. Thanks! |
Hi @karlosvalverde, I read the explanation. It was on the same line as I recommended on Discord, so good news. I'm just surprised you changed all your anchors for an other structure than the one we discussed (mentioning the |
No, it's fine. If you can live with the inconsistency, we can keep it like that. Most of the time you're not guessing an anchor name when referencing it from another page; you copy-paste it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate+
2279fc4
to
56ea0ee
Compare
[IMP] Website Themes - Going Live - Content update and additions - Screenshot - New anchors [FIX] Fix after code review [FIX] Anchor to noupdate attribute
56ea0ee
to
bea70e1
Compare
@robodoo r+ |
[IMP] Website Themes - Going Live - Content update and additions - Screenshot - New anchors [FIX] Fix after code review [FIX] Anchor to noupdate attribute closes #12225 Signed-off-by: Brandon Mercier (bram) <bram@odoo.com>
@bram-odoo staging failed: ci/l10n on 806c34239bcd42ebab2f6257cb4563ce448be9fa (view more at https://runbot.odoo.com/runbot/build/76656540) |
[IMP] Website Themes - Going Live - Content update and additions - Screenshot - New anchors [FIX] Fix after code review [FIX] Anchor to noupdate attribute closes #12225 Signed-off-by: Brandon Mercier (bram) <bram@odoo.com>
@bram-odoo staging failed: ci/l10n on cb628eec149cd4b758ebbc2073e8c5796073d0cc (view more at https://runbot.odoo.com/runbot/build/76656753) |
This staging failed for probably sprurious reasons, we've reset the PR, it should be re-staged soon-ish. |
[IMP] Website Themes - Going Live - Content update and additions - Screenshot - New anchors [FIX] Fix after code review [FIX] Anchor to noupdate attribute closes #12225 Signed-off-by: Brandon Mercier (bram) <bram@odoo.com>
This PR updates current "Going Live" page:
Task-4316611