Skip to content

[IMP] howtos/website_themes: Rework of the "Going live" page #12225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bram-odoo
Copy link
Contributor

This PR updates current "Going Live" page:

  • Content update and additions
  • Screenshot
  • New anchors

Task-4316611

@bram-odoo bram-odoo added the 16.0 label Feb 28, 2025
@bram-odoo bram-odoo requested a review from a team February 28, 2025 10:28
@robodoo
Copy link
Collaborator

robodoo commented Feb 28, 2025

Pull request status dashboard

@bram-odoo bram-odoo changed the title [IMP] Website Themes - Going Live [IMP] howtos/website_themes: Rework of the "Going live" page Feb 28, 2025
@bram-odoo bram-odoo force-pushed the 16.0-website-howto-theming-going-live-bram branch 2 times, most recently from 6875bbc to e8bc918 Compare February 28, 2025 10:42
@karlosvalverde
Copy link
Contributor

Hi @bram-odoo , as discussed with @AntoineVDV here, we should update the anchors structure following a website_themes/page/section_title structure.

Make sure you update your other PRs accordingly. Thanks!

@bram-odoo
Copy link
Contributor Author

bram-odoo commented Mar 10, 2025

Hi @bram-odoo , as discussed with @AntoineVDV here, we should update the anchors structure following a website_themes/page/section_title structure.

Make sure you update your other PRs accordingly. Thanks!

Hi @karlosvalverde, I read the explanation. It was on the same line as I recommended on Discord, so good news. I'm just surprised you changed all your anchors for an other structure than the one we discussed (mentioning the howtos folder to avoid colliding with the Tutorials CEDE is reworking). I guess I'll have to amend all my PRs accordiingly then 😅

@AntoineVDV
Copy link
Collaborator

Hi @bram-odoo , as discussed with @AntoineVDV here, we should update the anchors structure following a website_themes/page/section_title structure.
Make sure you update your other PRs accordingly. Thanks!

Hi @karlosvalverde, I read the explanation. It was on the same line as I recommended on Discord, so good news. I'm just surprised you changed all your anchors for an other structure than the one we discussed (mentioning the howtos folder to avoid colliding with the Tutorials CEDE is reworking). I guess I'll have to amend all my PRs accordiingly then 😅

No, it's fine. If you can live with the inconsistency, we can keep it like that. Most of the time you're not guessing an anchor name when referencing it from another page; you copy-paste it.

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

@AntoineVDV AntoineVDV removed the 16.0 label Mar 13, 2025
@bram-odoo bram-odoo force-pushed the 16.0-website-howto-theming-going-live-bram branch 2 times, most recently from 2279fc4 to 56ea0ee Compare March 15, 2025 13:24
[IMP] Website Themes - Going Live

- Content update and additions
- Screenshot
- New anchors

[FIX] Fix after code review

[FIX] Anchor to noupdate attribute
@bram-odoo bram-odoo force-pushed the 16.0-website-howto-theming-going-live-bram branch from 56ea0ee to bea70e1 Compare March 15, 2025 13:36
@bram-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 15, 2025
[IMP] Website Themes - Going Live

- Content update and additions
- Screenshot
- New anchors

[FIX] Fix after code review

[FIX] Anchor to noupdate attribute

closes #12225

Signed-off-by: Brandon Mercier (bram) <bram@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Mar 15, 2025

@bram-odoo staging failed: ci/l10n on 806c34239bcd42ebab2f6257cb4563ce448be9fa (view more at https://runbot.odoo.com/runbot/build/76656540)

@odoo odoo deleted a comment from robodoo Mar 15, 2025
@odoo odoo deleted a comment from robodoo Mar 15, 2025
robodoo pushed a commit that referenced this pull request Mar 15, 2025
[IMP] Website Themes - Going Live

- Content update and additions
- Screenshot
- New anchors

[FIX] Fix after code review

[FIX] Anchor to noupdate attribute

closes #12225

Signed-off-by: Brandon Mercier (bram) <bram@odoo.com>
@odoo odoo deleted a comment from robodoo Mar 15, 2025
@odoo odoo deleted a comment from robodoo Mar 15, 2025
@robodoo
Copy link
Collaborator

robodoo commented Mar 15, 2025

@bram-odoo staging failed: ci/l10n on cb628eec149cd4b758ebbc2073e8c5796073d0cc (view more at https://runbot.odoo.com/runbot/build/76656753)

@robodoo
Copy link
Collaborator

robodoo commented Mar 15, 2025

This staging failed for probably sprurious reasons, we've reset the PR, it should be re-staged soon-ish.

robodoo pushed a commit that referenced this pull request Mar 15, 2025
[IMP] Website Themes - Going Live

- Content update and additions
- Screenshot
- New anchors

[FIX] Fix after code review

[FIX] Anchor to noupdate attribute

closes #12225

Signed-off-by: Brandon Mercier (bram) <bram@odoo.com>
@robodoo robodoo closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants