Skip to content

Conversation

LoredanaLrpz
Copy link
Contributor

task-3090872

@robodoo
Copy link
Collaborator

robodoo commented Jun 13, 2025

Pull request status dashboard

@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch 2 times, most recently from fa3edff to cade9f6 Compare June 20, 2025 08:20
@LoredanaLrpz LoredanaLrpz marked this pull request as ready for review June 20, 2025 08:20
@LoredanaLrpz LoredanaLrpz requested a review from emmi-odoo June 20, 2025 08:20
@C3POdoo C3POdoo requested a review from a team June 20, 2025 08:22
Copy link
Contributor

@emmi-odoo emmi-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc, @LoredanaLrpz , I added some suggestions to reduce the amount of pronouns and turn passive sentences into active ones. You could also harmonize your headers a bit, some contain nouns only (Configuration, Default credit limit) while others have active verbs (Settle due accounts).

@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch from cade9f6 to 66d0259 Compare July 1, 2025 09:15
@LoredanaLrpz LoredanaLrpz requested a review from emmi-odoo July 1, 2025 09:15
@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch 2 times, most recently from f397bcf to 4fbece5 Compare July 1, 2025 12:35
@LoredanaLrpz LoredanaLrpz requested a review from auva-odoo July 1, 2025 12:35
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LoredanaLrpz , thank you for your work on this! I had a few notes and suggestions after reviewing and testing the instructions:

  • The Payment methods doc page is outdated, and since it is a central part of this doc, I think it'd be a good idea to update it as well (we could create another task for this if you prefer, of course!).
  • When I tested this in 18.0 with just the Invoicing app, I didn't have the Customer statements smart button on the customer form, nor the Settle due accounts option in the hamburger menu that you mention later on in this doc. Note that this changed somewhere along the way (it works in 18.4 with just Invoicing). Note that "Settle due accounts" becomes "Settle invoices" in 18.4 at least, I didn't check the other versions.
  • I think we should clarify somewhere that allowing customers to "purchase on credit" really just means creating an invoice that they’ll pay later. When using the Customer Credit payment method, no payment is actually registered at the time, since the invoice hasn’t been paid yet. I would make that clear.
  • I’d suggest grouping all the info about order processing, like selecting a customer, choosing a payment method, and enabling Invoice, in one section to make the workflow easier to follow.

@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch 2 times, most recently from 6872084 to 554aec1 Compare August 11, 2025 14:09
@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch 2 times, most recently from 8b0b1c0 to 209d563 Compare August 19, 2025 14:05
@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch from 209d563 to c66e593 Compare September 8, 2025 20:30
@LoredanaLrpz LoredanaLrpz marked this pull request as draft September 12, 2025 08:53
@LoredanaLrpz LoredanaLrpz changed the base branch from 18.0 to saas-18.4 September 12, 2025 11:19
@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch 3 times, most recently from 57d7b97 to 513e4db Compare September 12, 2025 12:07
@LoredanaLrpz LoredanaLrpz marked this pull request as ready for review September 12, 2025 12:07
@LoredanaLrpz
Copy link
Contributor Author

Edit: I rebased for saas-18.4

@C3POdoo C3POdoo requested a review from a team September 12, 2025 12:11
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @LoredanaLrpz 🙂 I added a few comments and suggestions; let me know if you'd like to discuss anything!

(PS: I did this review in between rounds of helping with release notes so I apologize in advance if any of my comments come across as a bit too direct 🙏)

@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch from 513e4db to 670e8ad Compare September 29, 2025 20:16
@LoredanaLrpz LoredanaLrpz force-pushed the 18.0-customer-credit-lrpz branch from 670e8ad to 4a1b62d Compare October 3, 2025 13:05
@LoredanaLrpz LoredanaLrpz requested a review from auva-odoo October 3, 2025 13:19
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @LoredanaLrpz! 🙂 This LGTM!

@LoredanaLrpz
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Oct 7, 2025
task-3090872

closes #13700

Signed-off-by: Loredana Perazzo (lrpz) <lrpz@odoo.com>
@robodoo robodoo closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants