-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[ADD] POS: customer credit as payment method #13700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa3edff
to
cade9f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice doc, @LoredanaLrpz , I added some suggestions to reduce the amount of pronouns and turn passive sentences into active ones. You could also harmonize your headers a bit, some contain nouns only (Configuration, Default credit limit) while others have active verbs (Settle due accounts).
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
cade9f6
to
66d0259
Compare
f397bcf
to
4fbece5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LoredanaLrpz , thank you for your work on this! I had a few notes and suggestions after reviewing and testing the instructions:
- The Payment methods doc page is outdated, and since it is a central part of this doc, I think it'd be a good idea to update it as well (we could create another task for this if you prefer, of course!).
- When I tested this in 18.0 with just the Invoicing app, I didn't have the Customer statements smart button on the customer form, nor the Settle due accounts option in the hamburger menu that you mention later on in this doc. Note that this changed somewhere along the way (it works in 18.4 with just Invoicing). Note that "Settle due accounts" becomes "Settle invoices" in 18.4 at least, I didn't check the other versions.
- I think we should clarify somewhere that allowing customers to "purchase on credit" really just means creating an invoice that they’ll pay later. When using the Customer Credit payment method, no payment is actually registered at the time, since the invoice hasn’t been paid yet. I would make that clear.
- I’d suggest grouping all the info about order processing, like selecting a customer, choosing a payment method, and enabling Invoice, in one section to make the workflow easier to follow.
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
6872084
to
554aec1
Compare
8b0b1c0
to
209d563
Compare
209d563
to
c66e593
Compare
57d7b97
to
513e4db
Compare
Edit: I rebased for saas-18.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work @LoredanaLrpz 🙂 I added a few comments and suggestions; let me know if you'd like to discuss anything!
(PS: I did this review in between rounds of helping with release notes so I apologize in advance if any of my comments come across as a bit too direct 🙏)
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/customer_credit.rst
Outdated
Show resolved
Hide resolved
513e4db
to
670e8ad
Compare
task-3090872
670e8ad
to
4a1b62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @LoredanaLrpz! 🙂 This LGTM!
@robodoo r+ |
task-3090872 closes #13700 Signed-off-by: Loredana Perazzo (lrpz) <lrpz@odoo.com>
task-3090872