[IMP] stripe: clarify the conditions for the support of a payment method #2543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the documentation was correct, it was confusing the reader to state that local payment methods are considered enabled if their related payment icon record does not exist in the database. The intended meaning was that this statement only holds if the local payment method is also supported, otherwise it cannot be enabled.
AntoineVDV
force-pushed
the
13.0-clarify-stripe-pms-anv
branch
from
9b03c69 to
6417fa8
Compare
|
Thanks for this @AntoineVDV. It's definitely clear ! |
toaa-odoo
approved these changes
Aug 11, 2022
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 17, 2022
Even though the documentation was correct, it was confusing the reader to state that local payment methods are considered enabled if their related payment icon record does not exist in the database. The intended meaning was that this statement only holds if the local payment method is also supported, otherwise it cannot be enabled. closes #2543 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the documentation was correct, it was confusing the reader
to state that local payment methods are considered enabled if their
related payment icon record does not exist in the database. The intended
meaning was that this statement only holds if the local payment method
is also supported, otherwise it cannot be enabled.
Note: the content structure is partly inspired by that in 15.0+ to ease the forward-port.