Skip to content

Conversation

tiku-odoo
Copy link
Contributor

@robodoo
Copy link
Collaborator

robodoo commented Apr 9, 2024

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-docs-reset-account-feature-tiku branch from e72eacd to 66d33eb Compare April 9, 2024 18:53
@tiku-odoo tiku-odoo marked this pull request as ready for review April 9, 2024 18:54
@tiku-odoo tiku-odoo requested a review from jevs-odoo April 9, 2024 18:54
@C3POdoo C3POdoo requested a review from a team April 9, 2024 18:54
@tiku-odoo
Copy link
Contributor Author

tiku-odoo commented Apr 9, 2024

@jev-odoo

Can you review the changes on this PR when you have a moment?

Outlook.rst
Lines: 140-182

Google.rst
Lines: 157-197

Thanks!

@tiku-odoo tiku-odoo requested a review from jero-odoo April 9, 2024 18:59
@tiku-odoo
Copy link
Contributor Author

tiku-odoo commented Apr 9, 2024

@jero-odoo

Can you peer reivew these two doc changes:
Outlook.rst
Lines: 140-182

Google.rst
Lines: 157-197

Thanks,
Tim 👍

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set @tiku-odoo just a few notes but I will approve now since they are minor. Nice job!

@jev-odoo
Copy link
Contributor

jev-odoo commented Apr 9, 2024

@tiku-odoo I assume you meant @jevs-odoo who created the task ?

@tiku-odoo
Copy link
Contributor Author

@tiku-odoo I assume you meant @jevs-odoo who created the task ?

@jev-odoo Yes, sorry about the mis-tagging.

👍

@tiku-odoo
Copy link
Contributor Author

@jevs-odoo

Can you review the changes on:
Outlook.rst
Lines: 140-182

Google.rst
Lines: 157-197

Thanks!

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-docs-reset-account-feature-tiku branch from 66d33eb to 03763e7 Compare April 10, 2024 14:10
@tiku-odoo tiku-odoo requested a review from ksc-odoo April 10, 2024 14:12
@tiku-odoo
Copy link
Contributor Author

@ksc-odoo

Can you review this doc when you have a moment?

Thanks,
Tim 👍

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tiku-odoo -- just finished my Final Review. Awesome job! Approving now. There is only a handful of minor adjustments that require your attention. Once those modifications have been completed, feel free to tag this for Tech Review. Thanks! 👍

Reset options
-------------

The following reset options are available for troubleshooting Google calendar sync with Odoo:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following reset options are available for troubleshooting Google calendar sync with Odoo:
The following reset options are available for troubleshooting *Google Calendar* sync with Odoo:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nudge

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-docs-reset-account-feature-tiku branch from 03763e7 to f44ae64 Compare April 12, 2024 20:22
@tiku-odoo
Copy link
Contributor Author

@StraubCreative

This doc is ready for your technical review when you have a moment.

Thanks, Tim

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiku-odoo
A couple quick comments below.
As well, there are lines that are either too long or too short in both docs. Please address them both before merge, thanks!

Reset options
-------------

The following reset options are available for troubleshooting Google calendar sync with Odoo:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nudge

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-docs-reset-account-feature-tiku branch from f44ae64 to 5e19330 Compare April 15, 2024 18:30
@tiku-odoo
Copy link
Contributor Author

@StraubCreative

Thanks for the review. I've made all the changes you requested.

Ready for merge.

Thanks,
Tim 👍

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-docs-reset-account-feature-tiku branch from 5e19330 to e702bd3 Compare April 15, 2024 18:41
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @tiku-odoo
..
@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Apr 15, 2024

@tiku-odoo @StraubCreative staging failed: ci/runbot on 6e5cf2b48f0697b82813f1f256d9a1f539c77ff5 (view more at https://runbot.odoo.com/runbot/build/61326379)

@tiku-odoo
Copy link
Contributor Author

@robodoo retry

@robodoo
Copy link
Collaborator

robodoo commented Apr 15, 2024

@tiku-odoo @StraubCreative staging failed: ci/runbot on d286a658046013086fb7e17a084afec4f739ba55 (view more at https://runbot.odoo.com/runbot/build/61326944)

@StraubCreative
Copy link
Contributor

@robodoo retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants