[IMP] commands: modify enum of CommandResult

When a command is rejected, the dispatch result contains a list of numbers,
which we then need to map to the enum by ourselves if we want to know the
actual reason of rejection.

This commit converts the enum of CommandResult from numbers to explicit
string values which describe the reason for command rejection in order to
save time while debugging.

Task ID : 3254446

closes #2845

Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: khpa-odoo

src/types/commands.ts

@@ -1067,102 +1067,102 @@ export class DispatchResult {
 export type CancelledReason = Exclude<CommandResult, CommandResult.Success>;
 
 export const enum CommandResult {
-  Success,
-  CancelledForUnknownReason,
-  WillRemoveExistingMerge,
-  MergeIsDestructive,
-  CellIsMerged,
-  InvalidTarget,
-  EmptyUndoStack,
-  EmptyRedoStack,
-  NotEnoughElements,
-  NotEnoughSheets,
-  MissingSheetName,
-  UnchangedSheetName,
-  DuplicatedSheetName,
-  DuplicatedSheetId,
-  ForbiddenCharactersInSheetName,
-  WrongSheetMove,
-  WrongSheetPosition,
-  InvalidAnchorZone,
-  SelectionOutOfBound,
-  TargetOutOfSheet,
-  WrongCutSelection,
-  WrongPasteSelection,
-  WrongPasteOption,
-  WrongFigurePasteOption,
-  EmptyClipboard,
-  EmptyRange,
-  InvalidRange,
-  InvalidZones,
-  InvalidSheetId,
-  InvalidFigureId,
-  InputAlreadyFocused,
-  MaximumRangesReached,
-  InvalidChartDefinition,
-  InvalidDataSet,
-  InvalidLabelRange,
-  InvalidScorecardKeyValue,
-  InvalidScorecardBaseline,
-  InvalidGaugeDataRange,
-  EmptyGaugeRangeMin,
-  GaugeRangeMinNaN,
-  EmptyGaugeRangeMax,
-  GaugeRangeMaxNaN,
-  GaugeRangeMinBiggerThanRangeMax,
-  GaugeLowerInflectionPointNaN,
-  GaugeUpperInflectionPointNaN,
-  GaugeLowerBiggerThanUpper,
-  InvalidAutofillSelection,
-  WrongComposerSelection,
-  MinBiggerThanMax,
-  LowerBiggerThanUpper,
-  MidBiggerThanMax,
-  MinBiggerThanMid,
-  FirstArgMissing,
-  SecondArgMissing,
-  MinNaN,
-  MidNaN,
-  MaxNaN,
-  ValueUpperInflectionNaN,
-  ValueLowerInflectionNaN,
-  MinInvalidFormula,
-  MidInvalidFormula,
-  MaxInvalidFormula,
-  ValueUpperInvalidFormula,
-  ValueLowerInvalidFormula,
-  InvalidSortZone,
-  WaitingSessionConfirmation,
-  MergeOverlap,
-  TooManyHiddenElements,
-  Readonly,
-  InvalidViewportSize,
-  InvalidScrollingDirection,
-  FigureDoesNotExist,
-  InvalidConditionalFormatId,
-  InvalidCellPopover,
-  EmptyTarget,
-  InvalidFreezeQuantity,
-  FrozenPaneOverlap,
-  ValuesNotChanged,
-  InvalidFilterZone,
-  FilterOverlap,
-  FilterNotFound,
-  MergeInFilter,
-  NonContinuousTargets,
-  DuplicatedFigureId,
-  InvalidSelectionStep,
-  DuplicatedChartId,
-  ChartDoesNotExist,
-  InvalidHeaderIndex,
-  InvalidQuantity,
-  MoreThanOneColumnSelected,
-  EmptySplitSeparator,
-  SplitWillOverwriteContent,
-  NoSplitSeparatorInSelection,
-  NoActiveSheet,
-  InvalidLocale,
-  AlreadyInPaintingFormatMode,
+  Success = "Success",
+  CancelledForUnknownReason = "CancelledForUnknownReason",
+  WillRemoveExistingMerge = "WillRemoveExistingMerge",
+  MergeIsDestructive = "MergeIsDestructive",
+  CellIsMerged = "CellIsMerged",
+  InvalidTarget = "InvalidTarget",
+  EmptyUndoStack = "EmptyUndoStack",
+  EmptyRedoStack = "EmptyRedoStack",
+  NotEnoughElements = "NotEnoughElements",
+  NotEnoughSheets = "NotEnoughSheets",
+  MissingSheetName = "MissingSheetName",
+  UnchangedSheetName = "UnchangedSheetName",
+  DuplicatedSheetName = "DuplicatedSheetName",
+  DuplicatedSheetId = "DuplicatedSheetId",
+  ForbiddenCharactersInSheetName = "ForbiddenCharactersInSheetName",
+  WrongSheetMove = "WrongSheetMove",
+  WrongSheetPosition = "WrongSheetPosition",
+  InvalidAnchorZone = "InvalidAnchorZone",
+  SelectionOutOfBound = "SelectionOutOfBound",
+  TargetOutOfSheet = "TargetOutOfSheet",
+  WrongCutSelection = "WrongCutSelection",
+  WrongPasteSelection = "WrongPasteSelection",
+  WrongPasteOption = "WrongPasteOption",
+  WrongFigurePasteOption = "WrongFigurePasteOption",
+  EmptyClipboard = "EmptyClipboard",
+  EmptyRange = "EmptyRange",
+  InvalidRange = "InvalidRange",
+  InvalidZones = "InvalidZones",
+  InvalidSheetId = "InvalidSheetId",
+  InvalidFigureId = "InvalidFigureId",
+  InputAlreadyFocused = "InputAlreadyFocused",
+  MaximumRangesReached = "MaximumRangesReached",
+  InvalidChartDefinition = "InvalidChartDefinition",
+  InvalidDataSet = "InvalidDataSet",
+  InvalidLabelRange = "InvalidLabelRange",
+  InvalidScorecardKeyValue = "InvalidScorecardKeyValue",
+  InvalidScorecardBaseline = "InvalidScorecardBaseline",
+  InvalidGaugeDataRange = "InvalidGaugeDataRange",
+  EmptyGaugeRangeMin = "EmptyGaugeRangeMin",
+  GaugeRangeMinNaN = "GaugeRangeMinNaN",
+  EmptyGaugeRangeMax = "EmptyGaugeRangeMax",
+  GaugeRangeMaxNaN = "GaugeRangeMaxNaN",
+  GaugeRangeMinBiggerThanRangeMax = "GaugeRangeMinBiggerThanRangeMax",
+  GaugeLowerInflectionPointNaN = "GaugeLowerInflectionPointNaN",
+  GaugeUpperInflectionPointNaN = "GaugeUpperInflectionPointNaN",
+  GaugeLowerBiggerThanUpper = "GaugeLowerBiggerThanUpper",
+  InvalidAutofillSelection = "InvalidAutofillSelection",
+  WrongComposerSelection = "WrongComposerSelection",
+  MinBiggerThanMax = "MinBiggerThanMax",
+  LowerBiggerThanUpper = "LowerBiggerThanUpper",
+  MidBiggerThanMax = "MidBiggerThanMax",
+  MinBiggerThanMid = "MinBiggerThanMid",
+  FirstArgMissing = "FirstArgMissing",
+  SecondArgMissing = "SecondArgMissing",
+  MinNaN = "MinNaN",
+  MidNaN = "MidNaN",
+  MaxNaN = "MaxNaN",
+  ValueUpperInflectionNaN = "ValueUpperInflectionNaN",
+  ValueLowerInflectionNaN = "ValueLowerInflectionNaN",
+  MinInvalidFormula = "MinInvalidFormula",
+  MidInvalidFormula = "MidInvalidFormula",
+  MaxInvalidFormula = "MaxInvalidFormula",
+  ValueUpperInvalidFormula = "ValueUpperInvalidFormula",
+  ValueLowerInvalidFormula = "ValueLowerInvalidFormula",
+  InvalidSortZone = "InvalidSortZone",
+  WaitingSessionConfirmation = "WaitingSessionConfirmation",
+  MergeOverlap = "MergeOverlap",
+  TooManyHiddenElements = "TooManyHiddenElements",
+  Readonly = "Readonly",
+  InvalidViewportSize = "InvalidViewportSize",
+  InvalidScrollingDirection = "InvalidScrollingDirection",
+  FigureDoesNotExist = "FigureDoesNotExist",
+  InvalidConditionalFormatId = "InvalidConditionalFormatId",
+  InvalidCellPopover = "InvalidCellPopover",
+  EmptyTarget = "EmptyTarget",
+  InvalidFreezeQuantity = "InvalidFreezeQuantity",
+  FrozenPaneOverlap = "FrozenPaneOverlap",
+  ValuesNotChanged = "ValuesNotChanged",
+  InvalidFilterZone = "InvalidFilterZone",
+  FilterOverlap = "FilterOverlap",
+  FilterNotFound = "FilterNotFound",
+  MergeInFilter = "MergeInFilter",
+  NonContinuousTargets = "NonContinuousTargets",
+  DuplicatedFigureId = "DuplicatedFigureId",
+  InvalidSelectionStep = "InvalidSelectionStep",
+  DuplicatedChartId = "DuplicatedChartId",
+  ChartDoesNotExist = "ChartDoesNotExist",
+  InvalidHeaderIndex = "InvalidHeaderIndex",
+  InvalidQuantity = "InvalidQuantity",
+  MoreThanOneColumnSelected = "MoreThanOneColumnSelected",
+  EmptySplitSeparator = "EmptySplitSeparator",
+  SplitWillOverwriteContent = "SplitWillOverwriteContent",
+  NoSplitSeparatorInSelection = "NoSplitSeparatorInSelection",
+  NoActiveSheet = "NoActiveSheet",
+  InvalidLocale = "InvalidLocale",
+  AlreadyInPaintingFormatMode = "AlreadyInPaintingFormatMode",
 }
 
 export interface CommandHandler<T> {