[FIX] chart: can UPDATE_CHART on a non-chart figure

The `checkChartExists` method is wrong, it only checks that a figure
with the id exists, not that it is a chart.

closes #6302

Task: 4775605
X-original-commit: 2004785
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/plugins/core/chart.ts

@@ -240,8 +240,6 @@ export class ChartPlugin extends CorePlugin<ChartState> implements ChartState {
   }
 
   private checkChartExists(cmd: UpdateChartCommand): CommandResult {
-    return this.getters.getFigureSheetId(cmd.id)
-      ? CommandResult.Success
-      : CommandResult.ChartDoesNotExist;
+    return this.isChartDefined(cmd.id) ? CommandResult.Success : CommandResult.ChartDoesNotExist;
   }
 }

tests/figures/chart/chart_plugin.test.ts

@@ -687,6 +687,26 @@ describe("datasource tests", function () {
     expect(result).toBeCancelledBecause(CommandResult.ChartDoesNotExist);
   });
 
+  test("reject updates that target a figure that is not a chart", () => {
+    model.dispatch("CREATE_FIGURE", {
+      sheetId: model.getters.getActiveSheetId(),
+      figure: { id: "2", x: 0, y: 0, width: 100, height: 100, tag: "not a chart" },
+    });
+
+    const result = model.dispatch("UPDATE_CHART", {
+      definition: {
+        dataSets: [],
+        dataSetsHaveTitle: false,
+        stacked: false,
+        legendPosition: "bottom",
+        title: { text: "test" },
+        type: "bar",
+      },
+      sheetId: model.getters.getActiveSheetId(),
+      id: "2",
+    });
+    expect(result).toBeCancelledBecause(CommandResult.ChartDoesNotExist);
+  });
   test("chart is not selected after creation and update", () => {
     const chartId = "1234";
     createChart(