[FW][FIX] range: show ref error after removing col/row in formulas #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previouly after we remove cols/rows that are used in formulas, the formula will not show error reminding invalid references, but keep the previous range and give the wrong results. This commit fixes this problem, so after deleting rows/cols the formulas refer to removed ones will show errors. The tests are co-authored with Adrien Minne (adrm). task 2719611 X-original-commit: a195f82 Co-authored-by: Adrien Minne <adrm@odoo.com>
|
@yunchen4 @rrahir this PR targets master and is the last of the forward-port chain containing: To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 21, 2023
Previouly after we remove cols/rows that are used in formulas, the formula will not show error reminding invalid references, but keep the previous range and give the wrong results. This commit fixes this problem, so after deleting rows/cols the formulas refer to removed ones will show errors. The tests are co-authored with Adrien Minne (adrm). task 2719611 closes #2249 X-original-commit: a195f82 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Yang Chenyun (chya) <chya@odoo.com> Co-authored-by: Adrien Minne <adrm@odoo.com>
fw-bot
deleted the
master-15.0-fix-range-ref-after-deleting-cols-chya-u7_u-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previouly after we remove cols/rows that are used in formulas, the formula will not show error reminding invalid references, but keep the previous range and give the wrong results.
This PR fixes this problem. After deleting rows/cols the formulas refer to removed ones will show errors. It's done by change
newRangewhen removing into an invalid range.The tests are co-authored with Adrien Minne (@hokolomopo).
Odoo task ID : 2719611
review checklist
Forward-Port-Of: #2242
Forward-Port-Of: #2162