[IMP] tests: improve readability of new Model() in tests
#2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Models are often initialized in the tests with a json object to initialize the sheets and cells. The problem is that we tend to define one attribute of the JSON per line of code, no matter the length of the line. - this means that initializing a single model takes 7-10 lines of code, which bloats the test file and makes them harder to scroll trough. - having a single attribute per line don't make the code of an individual test much more readable IMO. I propose to discard useless newLines, and try to reduce the lines of code to initialize the model (while still running prettier). This makes the tests more readable. Odoo task 3256031
hokolomopo
force-pushed
the
master-test-new-model-prettify-adrm
branch
from
98fb0c7
to
ac1abb4
Compare
hokolomopo
changed the title
new Model() in tests
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2023
Models are often initialized in the tests with a json object to initialize the sheets and cells. The problem is that we tend to define one attribute of the JSON per line of code, no matter the length of the line. - this means that initializing a single model takes 7-10 lines of code, which bloats the test file and makes them harder to scroll trough. - having a single attribute per line don't make the code of an individual test much more readable IMO. I propose to discard useless newLines, and try to reduce the lines of code to initialize the model (while still running prettier). This makes the tests more readable. Odoo task 3256031 closes #2290 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Models are often initialized in the tests with a json object to initialize the sheets and cells. The problem is that we tend to define one attribute of the JSON per line of code, no matter the length of the line.
I propose to discard useless newLines, and try to reduce the lines of code to initialize the model (while still running prettier). This makes the tests more readable.
Odoo task ID : 3256031
review checklist