[FW][FIX] conditional_formatting: fix cf type checkboxes #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkboxes of the CF side panel weren't working properly if we clicked right between the checkbox input and it's label. The state of the component changed, but the checkbox wasn't checked. This is because we used `t-attf-checked` to defined the state of the checkbox, which returns a string instead of a boolean. Changed it to `t-att-checked`. X-original-commit: 183d380
|
This PR targets saas-16.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Jun 1, 2023
The checkboxes of the CF side panel weren't working properly if we clicked right between the checkbox input and it's label. The state of the component changed, but the checkbox wasn't checked. This is because we used `t-attf-checked` to defined the state of the checkbox, which returns a string instead of a boolean. Changed it to `t-att-checked`. closes #2534 X-original-commit: 183d380 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Minne Adrien (adrm) <adrm@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
fw-bot
deleted the
saas-16.1-15.0-fix-cf-side-panel-checkbox-adrm-53I_-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkboxes of the CF side panel weren't working properly if we clicked right between the checkbox input and it's label. The state of the component changed, but the checkbox wasn't checked.
This is because we used
t-attf-checkedto defined the state of the checkbox, which returns a string instead of a boolean. Changed it tot-att-checked.Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #2530
Forward-Port-Of: #2528