Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] data_validation: prevent icon overlap #4085

Closed
wants to merge 2 commits into from

Conversation

hokolomopo
Copy link
Contributor

Description:

A same cell could have a data validation icon and a filter icon at
the same time, possibly causing overlap.

This commit disable the data validation icons on cells that have a
filter icon.

Note: for future work (in master), it'd be nice if we could create
a generic way to display a grid icon that would ensure that there is
no two icons on the same cell, and not handle them on a case by case
basis.

Task: : 3684182

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

A same cell could have a data validation icon and a filter icon at
the same time, possibly causing overlap.

This commit disable the data validation icons on cells that have a
filter icon.

Note: for future work (in master), it'd be nice if we could create
a generic way to display a grid icon that would ensure that there is
no two icons on the same cell, and not handle them on a case by case
basis.

Task: 3684182
@robodoo
Copy link
Collaborator

robodoo commented Apr 16, 2024

Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo rebase-ff r+

robodoo pushed a commit that referenced this pull request Apr 29, 2024
@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2024

Merge method set to rebase and fast-forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants