-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] data_validation: prevent icon overlap #4151
[FW][FIX] data_validation: prevent icon overlap #4151
Conversation
@hokolomopo @pro-odoo cherrypicking of pull request #4085 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
2199140
to
df3f417
Compare
@robodoo r+ |
A same cell could have a data validation icon and a filter icon at the same time, possibly causing overlap. This commit disable the data validation icons on cells that have a filter icon. Note: for future work (in master), it'd be nice if we could create a generic way to display a grid icon that would ensure that there is no two icons on the same cell, and not handle them on a case by case basis. Task: 3684182
df3f417
to
411800b
Compare
@robodoo r+ |
A same cell could have a data validation icon and a filter icon at the same time, possibly causing overlap. This commit disable the data validation icons on cells that have a filter icon. Note: for future work (in master), it'd be nice if we could create a generic way to display a grid icon that would ensure that there is no two icons on the same cell, and not handle them on a case by case basis. closes #4151 Task: 3684182 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
Description:
A same cell could have a data validation icon and a filter icon at
the same time, possibly causing overlap.
This commit disable the data validation icons on cells that have a
filter icon.
Note: for future work (in master), it'd be nice if we could create
a generic way to display a grid icon that would ensure that there is
no two icons on the same cell, and not handle them on a case by case
basis.
Task: : 3684182
review checklist
Forward-Port-Of: #4085