[FW][PERF] helpers: reduce toZone memory allocation #4175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On RNG' spreadsheet, this changes reduces memory allocation of `toZoneWithoutBoundaryChanges` by ~40Mb when loading the spreadsheet. It was ~93Mb before. Two changes: - avoid compiling a regexp every time - avoid useless array allocation when it's a single cell reference Each change accounts for ~20Mb saved. Task: 3915798 X-original-commit: cefa559
|
@LucasLefevre @rrahir this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+
…On Tue, May 7, 2024 at 11:53 AM Otis - Odoo Forward-Port Steward [bot] < ***@***.***> wrote:
@LucasLefevre <https://github.com/LucasLefevre> @rrahir
<https://github.com/rrahir> this PR targets master and is the last of the
forward-port chain containing:
- #4174 <#4174>
- #4173 <#4173>
To merge the full chain, use
@fw-bot <https://github.com/fw-bot> r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
—
Reply to this email directly, view it on GitHub
<#4175 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTHFEP2QAWMD66DCDWXUFTZBCQBRAVCNFSM6AAAAABHKUTJZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXHEYDMMRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
robodoo
pushed a commit
that referenced
this pull request
May 7, 2024
On RNG' spreadsheet, this changes reduces memory allocation of `toZoneWithoutBoundaryChanges` by ~40Mb when loading the spreadsheet. It was ~93Mb before. Two changes: - avoid compiling a regexp every time - avoid useless array allocation when it's a single cell reference Each change accounts for ~20Mb saved. closes #4175 Task: 3915798 X-original-commit: cefa559 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 7, 2024
On RNG' spreadsheet, this changes reduces memory allocation of `toZoneWithoutBoundaryChanges` by ~40Mb when loading the spreadsheet. It was ~93Mb before. Two changes: - avoid compiling a regexp every time - avoid useless array allocation when it's a single cell reference Each change accounts for ~20Mb saved. closes #4175 Task: 3915798 X-original-commit: cefa559 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RNG' spreadsheet, this changes reduces memory allocation of
toZoneWithoutBoundaryChangesby ~40Mb when loading the spreadsheet. It was ~93Mb before.Two changes:
Each change accounts for ~20Mb saved.
Task: 3915798
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #4172