Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] autocomplete: fix pivot group autocomplete #4420

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jun 11, 2024

The computation to autocomplete pivot group values was only supporting string-like group values. If a user were to write some random input, like a number, the code would crash.

Task: 3976271

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4419

The computation to autocomplete pivot group values was only supporting
string-like group values. If a user were to write some random input,
like a number, the code would crash.

Task: 3976271
X-original-commit: e3cb344
@robodoo
Copy link
Collaborator

robodoo commented Jun 11, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 11, 2024

@rrahir @pro-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jun 11, 2024
The computation to autocomplete pivot group values was only supporting
string-like group values. If a user were to write some random input,
like a number, the code would crash.

closes #4420

Task: 3976271
X-original-commit: e3cb344
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Jun 11, 2024
@robodoo robodoo added the 17.4 label Jun 11, 2024
@fw-bot fw-bot deleted the master-saas-17.3-fix-pivot-autocomplete-rar-_67_-fw branch June 25, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants