Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] functions: allow to match empty cells #4620

Closed
wants to merge 2 commits into from
Closed

[FW][FIX] functions: allow to match empty cells #4620

wants to merge 2 commits into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 8, 2024

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : 4023057

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4618
Forward-Port-Of: #4580

@LucasLefevre
[FIX] functions: match empty cells
d376e33 
in an empty sheet, in A1, type =COUNTIF(A2, "<>Hi")
=> the result is 0.
It should be 1 because A2 is different than 'Hi'

opw-4023057

Task: 4023057
X-original-commit: 62f4af8
@LucasLefevre
[FIX] functions: "*" doesn't match empty string
ce915a5 
in an empty sheet, in A1, type =COUNTIF(A2, "*")
=> the result is 1.

It should be 0, empty cells should be ignored

opw-4023057

Task: 4023057
X-original-commit: dd9f5a3
@robodoo
Copy link
Collaborator

robodoo commented Jul 8, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 8, 2024

This PR targets saas-17.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Jul 8, 2024
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Jul 8, 2024
@LucasLefevre
[FIX] functions: match empty cells
cf0e82d 
in an empty sheet, in A1, type =COUNTIF(A2, "<>Hi")
=> the result is 0.
It should be 1 because A2 is different than 'Hi'

opw-4023057

Task: 4023057
X-original-commit: 62f4af8
Part-of: #4620
Signed-off-by: Alexis Lacroix (laa) <laa@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this in 63f3c38 Jul 8, 2024
@fw-bot fw-bot deleted the saas-17.3-15.0-predicate-empty-cells-lul-70N1-fw branch July 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fw-bot @robodoo @LucasLefevre