Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] point_of_sale: load product requests #124223

Closed

Conversation

rhe-odoo
Copy link
Contributor

@rhe-odoo rhe-odoo commented Jun 8, 2023

When the pos was loading only a part of the products, the request should follow those rules order:

  • product is a favorite
  • product is a service
  • product had stock moves soon
  • product update

But this request didn't take into account consumables products and if there was no stock move, the value was null and postgres consider null values first when ordering desc. Now with that changes, the order is correctly set based on the rules above.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Jun 8, 2023

@C3POdoo C3POdoo requested review from a team and caburj and removed request for a team June 8, 2023 08:36
@C3POdoo C3POdoo added the RD research & development, internal work label Jun 8, 2023
When the pos was loading only a part of the products, the request should follow those rules order:
- product is a favorite
- product is a service
- product had stock moves soon
- product update

But this request didn't take into account consumables products and if there was no stock move,
the value was null and postgres consider null values first when ordering desc.
Now with that changes, the order is correctly set based on the rules above.
@rhe-odoo rhe-odoo force-pushed the 16.0-pos-loading-product-request-rhe branch from 432f299 to 68ef85c Compare June 8, 2023 09:44
@davidmonnom
Copy link
Contributor

@robodoo r+

@fw-bot
Copy link
Contributor

fw-bot commented Jun 12, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

7 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Jun 13, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot
Copy link
Contributor

fw-bot commented Jun 14, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot
Copy link
Contributor

fw-bot commented Jun 15, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot
Copy link
Contributor

fw-bot commented Jun 16, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot
Copy link
Contributor

fw-bot commented Jun 17, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot
Copy link
Contributor

fw-bot commented Jun 18, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot
Copy link
Contributor

fw-bot commented Jun 20, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):
#124313

@fw-bot fw-bot deleted the 16.0-pos-loading-product-request-rhe branch June 22, 2023 14:46
@fw-bot
Copy link
Contributor

fw-bot commented Jun 28, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Jul 14, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Aug 15, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Contributor

fw-bot commented Oct 18, 2023

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Feb 23, 2024

@rhe-odoo @davidmonnom this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants