[FW][FIX] point_of_sale: load product requests #124350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhe-odoo @davidmonnom cherrypicking of pull request #124223 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
forwardport
rhe-odoo
force-pushed
the
saas-16.3-16.0-pos-loading-product-request-rhe-yCj8-fw
branch
from
f2722ca
to
d45bdae
Compare
When the pos was loading only a part of the products, the request should follow those rules order: - product is a favorite - product is a service - product had stock moves soon - product update But this request didn't take into account consumables products and if there was no stock move, the value was null and postgres consider null values first when ordering desc. Now with that changes, the order is correctly set based on the rules above. X-original-commit: 102791f
rhe-odoo
force-pushed
the
saas-16.3-16.0-pos-loading-product-request-rhe-yCj8-fw
branch
from
d45bdae
to
5ebb631
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 29, 2023
When the pos was loading only a part of the products, the request should follow those rules order: - product is a favorite - product is a service - product had stock moves soon - product update But this request didn't take into account consumables products and if there was no stock move, the value was null and postgres consider null values first when ordering desc. Now with that changes, the order is correctly set based on the rules above. closes #124350 X-original-commit: 102791f Signed-off-by: David Monnom (moda) <moda@odoo.com>
fw-bot
deleted the
saas-16.3-16.0-pos-loading-product-request-rhe-yCj8-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pos was loading only a part of the products, the request should follow those rules order:
But this request didn't take into account consumables products and if there was no stock move, the value was null and postgres consider null values first when ordering desc. Now with that changes, the order is correctly set based on the rules above.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #124223