Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] point_of_sale: load product requests #126782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jun 29, 2023

When the pos was loading only a part of the products, the request should follow those rules order:

  • product is a favorite
  • product is a service
  • product had stock moves soon
  • product update

But this request didn't take into account consumables products and if there was no stock move, the value was null and postgres consider null values first when ordering desc. Now with that changes, the order is correctly set based on the rules above.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #124350
Forward-Port-Of: #124223

When the pos was loading only a part of the products, the request should follow those rules order:
- product is a favorite
- product is a service
- product had stock moves soon
- product update

But this request didn't take into account consumables products and if there was no stock move,
the value was null and postgres consider null values first when ordering desc.
Now with that changes, the order is correctly set based on the rules above.

X-original-commit: f38bea2
@robodoo
Copy link
Contributor

robodoo commented Jun 29, 2023

@fw-bot
Copy link
Contributor Author

fw-bot commented Jun 29, 2023

@rhe-odoo @davidmonnom this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Jun 29, 2023
@C3POdoo C3POdoo added the RD research & development, internal work label Jun 29, 2023
@rhe-odoo
Copy link
Contributor

@fw-bot r+

@robodoo
Copy link
Contributor

robodoo commented Jan 11, 2024

@rhe-odoo @davidmonnom unable to stage: merge conflict

@lathama
Copy link
Contributor

lathama commented Apr 15, 2024

Initial guess on the blockage to be 2fbc5cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants