[FIX] web: show event date/duration on popover #160907

kawkb · 2024-04-08T10:21:33Z

Issue:

when you open a calendar event popover, you can't see its time and duration

Steps To Reproduce:

In mobile view, go to calendar and create an event.
Click on the event and notice you can't see it's time and duration.

Solution:

We want to display the time in the popover for all modes. Therefore, I removed the scale === "month" condition from showTime. The showTime variable is used to set the isTimeHidden attribute, which is then checked in the computeDateTimeAndDuration function of the calendar popover.

opw-3829004

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2024-04-08T10:22:12Z

Pull request status dashboard.

nle-odoo

there is the same issue on desktop, but maybe it's less of an issue since you can kind of see it in the view below:

when in mobile, the time is also in the view but the popup recover everything.

In my opinion (but this may have other repercussion), we should probably show it in all case if it's what we want, so remove the line:

https://github.com/odoo/odoo/blob/saas-16.3/addons/web/static/src/views/calendar/calendar_model.js#L518

Or if we only want it in modal, I think you could do your change in that line instead.

Because it seems to me that if we show the time it would make sense to have "isTimeHidden" set to false, this boolean seems to be intended for that as far as I can tell.

edit: side note, in the ticket it is said that we don't see the hours in the calendar view (which validates well to show them on mobile), but when I test I see them so I'm not sure what's different:

kawkb · 2024-04-10T14:16:19Z

Hello @nle-odoo,

Thank you for your review.

For the desktop version, the event hours and duration have been intentionally removed, as they can be directly viewed on the calendar event itself.

Regarding the mobile version, the event hours and duration are not visible in version 17.0. However, I have decided to implement the fix in version 16.3, since their visibility on the event is quite limited and they appear very small. Therefore, it is preferable to view them on the popup.

Issue: - when you open a calendar event popover , you can't see its time and duration Steps To Reproduce: - Go to calendar and create an event. - Click on the event and notice you can't see it's time and duration in popover. Solution: - We want to display the time in the popover for all modes. Therefore, I removed the scale === "month" condition from showTime. The showTime variable is used to set the isTimeHidden attribute, which is then checked in the computeDateTimeAndDuration function of the calendar popover. opw-3829004

mcm-odoo

@robodoo r+

Issue: - when you open a calendar event popover , you can't see its time and duration Steps To Reproduce: - Go to calendar and create an event. - Click on the event and notice you can't see it's time and duration in popover. Solution: - We want to display the time in the popover for all modes. Therefore, I removed the scale === "month" condition from showTime. The showTime variable is used to set the isTimeHidden attribute, which is then checked in the computeDateTimeAndDuration function of the calendar popover. opw-3829004 closes #160907 Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>

fw-bot · 2024-05-20T05:53:55Z