-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] web: show event date/duration on popover #166408
[FW][FIX] web: show event date/duration on popover #166408
Conversation
@kawkb @mcm-odoo cherrypicking of pull request #160907 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
97c5be3
to
43ec907
Compare
@robodoo r+ |
43ec907
to
681ad64
Compare
@robodoo r+ |
Issue: - when you open a calendar event popover , you can't see its time and duration Steps To Reproduce: - Go to calendar and create an event. - Click on the event and notice you can't see it's time and duration in popover. Solution: - We want to display the time in the popover for all modes. Therefore, I removed the scale === "month" condition from showTime. The showTime variable is used to set the isTimeHidden attribute, which is then checked in the computeDateTimeAndDuration function of the calendar popover. opw-3829004 X-original-commit: e17f28d
681ad64
to
ecaae0b
Compare
@robodoo r+ |
Issue: - when you open a calendar event popover , you can't see its time and duration Steps To Reproduce: - Go to calendar and create an event. - Click on the event and notice you can't see it's time and duration in popover. Solution: - We want to display the time in the popover for all modes. Therefore, I removed the scale === "month" condition from showTime. The showTime variable is used to set the isTimeHidden attribute, which is then checked in the computeDateTimeAndDuration function of the calendar popover. opw-3829004 closes #166408 X-original-commit: e17f28d Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com> Signed-off-by: Kawtar Drissi El Bouzaidi (kdeb) <kdeb@odoo.com>
Issue:
Steps To Reproduce:
Solution:
scale === "month"
condition fromshowTime
. TheshowTime
variable is used to set theisTimeHidden
attribute, which is then checked in thecomputeDateTimeAndDuration
function of the calendar popover.opw-3829004
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #166279
Forward-Port-Of: #160907