[FW][FIX] web: show event date/duration on popover #166279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Issue:
- when you open a calendar event popover ,
you can't see its time and duration
Steps To Reproduce:
- Go to calendar and create an event.
- Click on the event and notice you can't
see it's time and duration in popover.
Solution:
- We want to display the time in the popover for all
modes. Therefore, I removed the scale === "month"
condition from showTime. The showTime variable is used
to set the isTimeHidden attribute, which is then checked
in the computeDateTimeAndDuration function of the calendar
popover.
opw-3829004
X-original-commit: c0017c2
kawkb
force-pushed
the
saas-17.1-saas-16.3-OPW-3829004-web_add_event_date_duration_on_mobile-kdeb-uSi9-fw
branch
from
200af82
to
0ab910d
Compare
|
@robodoo r+ |
C3POdoo
requested review from
a team,
Iucapad and
juliusc2066
and removed request for
a team
robodoo
pushed a commit
that referenced
this pull request
May 22, 2024
Issue:
- when you open a calendar event popover ,
you can't see its time and duration
Steps To Reproduce:
- Go to calendar and create an event.
- Click on the event and notice you can't
see it's time and duration in popover.
Solution:
- We want to display the time in the popover for all
modes. Therefore, I removed the scale === "month"
condition from showTime. The showTime variable is used
to set the isTimeHidden attribute, which is then checked
in the computeDateTimeAndDuration function of the calendar
popover.
opw-3829004
closes #166279
X-original-commit: c0017c2
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Signed-off-by: Kawtar Drissi El Bouzaidi (kdeb) <kdeb@odoo.com>
fw-bot
deleted the
saas-17.1-saas-16.3-OPW-3829004-web_add_event_date_duration_on_mobile-kdeb-uSi9-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Steps To Reproduce:
Solution:
scale === "month"condition fromshowTime. TheshowTimevariable is used to set theisTimeHiddenattribute, which is then checked in thecomputeDateTimeAndDurationfunction of the calendar popover.opw-3829004
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #165793
Forward-Port-Of: #160907