Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] point_of_sale: correctly reconcile reversed payments #162633

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 19, 2024

Current behavior:
When an order is invoided after the session has been closed, a reversed payment is created. This payment is not reconciled correctly with the invoice. This is creating an aged receivable for the partner.

Steps to reproduce:

  • Change the bank payment method to "Identify customer"
  • Create an order in the PoS and pay with bank and specify a partner
  • Close the session
  • Open the session again, and create an invoice for the order
  • Go to the accounting module and look for the aged receivable report you should see some entries under the partner you selected.
  • You can also go to the partner form and see that he has some due invoices.

opw-3678298

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #156527

Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

X-original-commit: 31aff38
@robodoo
Copy link
Contributor

robodoo commented Apr 19, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 19, 2024

This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 19, 2024
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 19, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 19, 2024

@robinengels @caburj the next pull request (#162653) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robinengels
Copy link
Contributor

@fw-bot r+

@robodoo
Copy link
Contributor

robodoo commented Apr 22, 2024

@robinengels @caburj linked pull request(s) odoo/enterprise#61151 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Apr 23, 2024
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

closes #162633

X-original-commit: 31aff38
Related: odoo/enterprise#61151
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
@robodoo robodoo closed this Apr 23, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 29, 2024

@robinengels @caburj ancestor PR #162601 has been updated but this PR is merged and can't be updated to match.

You may want or need to manually update any followup PR.

4 similar comments
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 29, 2024

@robinengels @caburj ancestor PR #162601 has been updated but this PR is merged and can't be updated to match.

You may want or need to manually update any followup PR.

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 29, 2024

@robinengels @caburj ancestor PR #162601 has been updated but this PR is merged and can't be updated to match.

You may want or need to manually update any followup PR.

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 29, 2024

@robinengels @caburj ancestor PR #162601 has been updated but this PR is merged and can't be updated to match.

You may want or need to manually update any followup PR.

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 29, 2024

@robinengels @caburj ancestor PR #162601 has been updated but this PR is merged and can't be updated to match.

You may want or need to manually update any followup PR.

@fw-bot fw-bot deleted the saas-16.4-16.0-opw-3678298-age_negative-roen-hC03-fw branch May 7, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants