Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] point_of_sale: correctly reconcile reversed payments #162653

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 19, 2024

Current behavior:
When an order is invoided after the session has been closed, a reversed payment is created. This payment is not reconciled correctly with the invoice. This is creating an aged receivable for the partner.

Steps to reproduce:

  • Change the bank payment method to "Identify customer"
  • Create an order in the PoS and pay with bank and specify a partner
  • Close the session
  • Open the session again, and create an invoice for the order
  • Go to the accounting module and look for the aged receivable report you should see some entries under the partner you selected.
  • You can also go to the partner form and see that he has some due invoices.

opw-3678298

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #156527

@robodoo
Copy link
Contributor

robodoo commented Apr 19, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 19, 2024

@robinengels @caburj cherrypicking of pull request #156527 failed.

stdout:

Auto-merging addons/point_of_sale/models/pos_order.py
Auto-merging addons/point_of_sale/models/pos_payment.py
Auto-merging addons/point_of_sale/tests/test_point_of_sale_flow.py
CONFLICT (content): Merge conflict in addons/point_of_sale/tests/test_point_of_sale_flow.py

stderr:

16:45:33.806997 git.c:463               trace: built-in: git cherry-pick e62186a990b2ee8145236d7e43b24faaa52c6fe5
error: could not apply e62186a990b2... [FIX] point_of_sale: correctly reconcile reversed payments
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Apr 19, 2024
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 19, 2024
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

X-original-commit: 31aff38
@robinengels robinengels force-pushed the 17.0-16.0-opw-3678298-age_negative-roen-RKkV-fw branch from 1527f47 to 00fdfae Compare April 22, 2024 09:12
@C3POdoo C3POdoo requested review from a team and caburj and removed request for a team April 22, 2024 09:15
@robinengels
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in 6b979c6 Apr 22, 2024
willylohws pushed a commit to willylohws/odoo that referenced this pull request May 1, 2024
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

closes odoo#162653

X-original-commit: 31aff38
Related: odoo/enterprise#61158
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
@fw-bot fw-bot deleted the 17.0-16.0-opw-3678298-age_negative-roen-RKkV-fw branch May 6, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants