[MERGE] forward port branch saas-12.4 up to 4a1321bc99d #37127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Commit: The statbutton on partner form does not work properly. After Commit: we change the domain because use the wrong domain in filter so statbutton not work properly on partnerform. task-id : 2041822 closes odoo#35290 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Fine tuning of 988e201 closes odoo#36628 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Some model can have really complex _order, which can induce unnecessary slow queries; here as we don't need the right business order we force ordering by 'id' instead OPW-2007478 closes odoo#36660 X-original-commit: a1fe897 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Before this commit, the barcode Qweb Field had a option called "type", which meant what is the mapping between numbers and barcode, that mapping is called a symbology https://www.barcoding.com/resources/barcoding-basics/barcode-symbologies/ This option "type" collided with what the qweb engine does at ``` qweb > _compile_directive_field that calls ir_qweb > _get_field ``` It resulted in a crash where type = "barcode" was not a valid symbology to pass to the barcode lib It is safe to say that this barcode widget was never user, otherwise it would have crashed This commit changes that non-functioning API, and the barcode renders well OPW 2066870 forward-port of odoo#36499 (330d862) closes odoo#36499 closes odoo#36658 Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com> Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Since odoo@01d0523, the _get_alias_values methods is called during the write on the mail.alias. In this method, the r.sub seems wrong & useless since the alias_name is also checked when writing on the mail.alias (alias_name is a related="alias_id.alias_name") with a different behavior that the r.sub. closes odoo#36668 --task: 2069650 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Steps to reproduce the bug: - Let's consider the storable product P and the vendor V - Set V as a supplier of P - Archive V - Go to product P and click on button "Replenish" Bug: A RFQ was created with the vendor V Now when archiving a vendor V, all the product.supplierinfo records linked to V will be archived. opw:2066616 closes odoo#36672 X-original-commit: 5040c17 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
-Go to Settings > General Settings and choose the external_layout_background template. -Set a client's language to French. -Go to Invoicing. -Select any invoice for this client, and click Print > Invoices Before this commit: At the bottom of the page you would see "XY" for the page number. After this commit: You now see "Page X sur Y". closes odoo#36643 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Simple typo; instead of a logger message, an exception is output in the logs. closes odoo#36686 X-original-commit: 83030b6 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
The name and address printed on any PDF report (e.g. SO or RFQ) is very likely to be split on 2 lines once it is long enough. For example, 'My Company (Chicago)' will be displayed on 2 lines. This is due to 0c6e0d6 and 064eb0a. opw-2061553 closes odoo#36498 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
If you:
- have a multilang COA
- create an account.account manually
- add a XML ID with structure {company_id}_{anything} manually
- reload COA translations (install COA language, install COA, set
installed COA since c346e7a)
=> there is an error since the code try to copy translations of
account.account.template associated to custom XML ID.
fix: ignore this torcivous use case
fixes odoo#36310
opw-2063207
closes odoo#36544
closes odoo#36659
X-original-commit: 0fc0b74
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
…ccount Before this commit: For a couple of clients, the installation of a chart of accounts crashes because a transfer account is not found. This account should have been created automatically, but hasn't, or has been deleted. After this commit: If no transfer account is found, no account is linked to the "Transfer account" field of the company, but the installation doesn't crash. closes odoo#36693 Opw: 2066557 X-original-commit: d93e5c1 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Before this commit, in a session with too many open orders the buttons in the upper right corner, next to the 'delete order button', i.e., the print button, the connection status, the print button and the close button, will be pushed out of view. This makes it impossible to check out, to print, etc., without closing orders. Now, a scrollbar appears when to many open order and allows to see the buttons in the right upper corner. opw-2064409 closes odoo#36724 X-original-commit: ace930f Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Steps to reproduce the bug: - Install l10n_de - Go in General settings - Set external_layout_din5008 as Document Template - Let's consider the customer C with an address and a VAT number - Create a SO with C - Print the SO Bug: The VAT number of C was not correctly displayed. opw:2069128 closes odoo#36673 X-original-commit: b50f512 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
When adding an analytic tag on a sale order line, if there is a default analytic tag defined matching the criteria, the tag on the SO line is overwritten in the invoice while it should be kept. opw-2068196 closes odoo#36685 closes odoo#36727 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
When .with_context() is called with a dictionary as 1st positional argument, it will replace context (and not modify the referenced keys) It may create bugs when losing the content of the context (e.g. remove partner's language) This is a partial merge of odoo#36164 without the inventory part as discussed. closes odoo#36729 X-forward: 4717ccf Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
…templates -Choose the document template 'external_layout_boxed' or 'external_layout_standard' for client in Spanish. -Print an invoice. Before this commit: the page numbering in the footer is not displayed properly. After this commit: the page numbering in the footer is displayed properly closes odoo#36741 Opw: 2066838 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Have a model with a parent field Set his parents like Parent 0 | -- Parent 1 | -- Parent 2 Now, put the Parent 1 as inactive Open a view with a search panel, which will fetch the parent field as categories Before this commit, it crashed, because the inner record memory did not contain a reference to the parent of Parent 2 After this commit, it doesn't crash, and the search panel just doesn't display parents categories that are archived, nor any children of those OPW 2070266 closes odoo#36699 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Forward-port of odoo#36688 (original: odoo#36284) Before this commit, search view was barely usable with Japanese IME. For instance, when pressing ENTER while in composition mode and IME prompts some suggestions, it made a search with the updated input content. The expected behaviour should have been to update the input content, without making the search yet. This commit fixes the issue by turning off some actions of the search view when typing during composition mode. opw-2061590 closes odoo#36728 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
- Activate variants - On a product variant without BOM, go to Action > Compute Price from BOM A zero-division is raised because of `... / bom.product_qty`. opw-2067520 closes odoo#36733 closes odoo#36736 closes odoo#36749 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Follow-up of the commit odoo/odoo@53285f1 closes odoo#36752 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Before this commit, when printing the Price List report of a Product Variant, the price is printed directly from the float result of the calculation of the price, even if this price is rounded, the representation of the float can have, sometimes, float precision errors (a lot of 0 after the decimal point, and a 1 or 2 at the end). Now, the function returns a string formatted to the correct number of fractional digits. opw-2069305 closes odoo#36705 closes odoo#36770 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
…has none For contract of type 'Company' which have no image set, we should display a specific default 'company' placeholder image instead of default placeholder. This allows to easily identify which records are companies. This was already the case up to commit 6153d65 OPW-2067475 closes odoo#36783 X-original-commit: 42c0884 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Since commit 5f12e24, the write of implied groups is done directly in SQL, bypassing the ORM writes, and thus bypassing the python constraints checks. In particular such a constraint was added in f206714. We add back an explicit check of this constraint; however we rewrite it in SQL to be fast. closes odoo#35411 closes odoo#36769 Signed-off-by: Nans Lefebvre (len) <len@odoo.com> Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
closes odoo#36801 X-original-commit: 0ae2236 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Animations (now public widgets) are now disabled by default in edit mode. It is opt-in. That one should have been enabled and was left disabled by mistake. task-2070930 closes odoo#36807 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Prior to this commit, we would try to decode the logo of a company without any verification on its presence. If the logo was not set, we'd try to decode nothing which caused a crash. This commit ensure that we asert that the field is set before trying to encode it for a JSON payload. closes odoo#36784 X-original-commit: f40f763 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Before this commit, users wasn't able to scroll vertically when there was "table-responsive" class on modal's table. In fact the scroll was effective on the body and not in the modal content. We can fix this issue by having flex elements but as this is a fix, we preferred to choose a one line fix solution. Steps to reproduce : * open Odoo in Safari (iOS) * open Sale app * create a new quotation * select a customer * select "Search More ..." * try to scroll the table vertically (BUG) Sources : https://stackoverflow.com/questions/41681251/overflow-x-scroll-inside-a-fixed-div-prevents-vertical-scrolling-on-ios#comment84970666_41693350 https://stackoverflow.com/a/57566116 opw-2042095 closes odoo#36707 closes odoo#36730 Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com> Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
- Activate mrp bom cost. - Create a BoM for a product - The Compute "Price from BoM" button appear on the product template below the Cost field. - Click the button. Before this commit: Probably because dynamic variant creation is activated and there is no variants, the ensure_one fails with 0 records actually passed to the function. Additionally, if all the BoM are for variants and there is no BoM for the template, then there is a division by 0 exception. After this commit: A test is performed to avoid calling the function with 0 records. A test is performed to avoid a division by 0 exception. closes odoo#36761 Opw: 2064884 X-original-commit: 4226400 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
…_sudo Be in multi-company, with shared products, let P be a product in company C. Suppose there are stock moves or pickings in company C'. Suppose a non-admin writes on P: it triggers an access error. Stock moves are not shared across companies in all cases. So fields that depend on product_id might trigger a recompute on stock.moves that are in another company, and thus trigger a spurious ACL error while simply writing product attributes. Note that _cal_move_weight depends on product_qty, however it is not sufficient to only put that field in compute_sudo; the product_qty has already been marked as todo, and so it is recomputed in the initial environment. opw 2066691 forward port of 7d4d8fa closes odoo#36838 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
- allow acquirers to arbitrarily include info about the tx in the processing page - pending is now a valid state that could require customer action in the payment processing page - don't blindly redirect to the return url of another tx if a pending transaction is there This latest change might mean that customers with many tx attempts might have a sub-par experience as they may need to click manually on the redirect url of a successful tx while before they were redirected immediately.
Task ID: 2060475 closes odoo#37172 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
KangOl
force-pushed
the
fp-saas-12.5-1909191154
branch
from
ba1c763
to
46826d4
Compare
|
robodoo merge review+ priority=0 |
|
Merge method set to merge directly, using the PR as merge commit message |
|
'ci/runbot' failed on this reviewed PR. |
|
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/627215) |
robodoo
added
error 🙅
and removed
CI 🤖
KangOl
force-pushed
the
fp-saas-12.5-1909191154
branch
from
46826d4
to
f096a36
Compare
|
robodoo merge review+ priority=0 |
robodoo
pushed a commit
that referenced
this pull request
Sep 20, 2019
closes #37127 Signed-off-by: Christophe Simonis <chs@odoo.com>
robodoo
added
CI 🤖
|
Merge method set to merge directly, using the PR as merge commit message |
KangOl
changed the title
|
Merged at 58a83d1, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.