Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX]stock_account: don't show consumable in valuation report #65786

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Feb 9, 2021

In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #65726

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Feb 9, 2021
@robodoo
Copy link
Contributor

robodoo commented Feb 9, 2021

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 9, 2021

Ping @yhu-odoo, @amoyaux
Cherrypicking 6de9f08 of source #65726 failed

stderr:

11:31:41.655844 git.c:344               trace: built-in: git cherry-pick 6de9f084c1383e210a79fc0318638c502f4bcce6
error: could not apply 6de9f084c13... [FIX]stock_account: don't show consumable in valuation report
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@C3POdoo C3POdoo added the RD research & development, internal work label Feb 9, 2021
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

X-original-commit: 57695f8
@yhu-odoo yhu-odoo force-pushed the 14.0-13.0-stock-valuation-no-consumable-yhu-ipma-fw branch from e1415a6 to 5b02f3a Compare February 12, 2021 08:34
@yhu-odoo
Copy link
Contributor

@amoyaux fixed the conflict

@amoyaux
Copy link
Contributor

amoyaux commented Feb 12, 2021

robodoo r+

@robodoo robodoo closed this in daee735 Feb 12, 2021
@robodoo robodoo temporarily deployed to merge February 12, 2021 11:42 Inactive
@fw-bot fw-bot deleted the 14.0-13.0-stock-valuation-no-consumable-yhu-ipma-fw branch February 26, 2021 11:46
fmdl pushed a commit to fmdl/odoo that referenced this pull request Apr 29, 2021
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

closes odoo#65786

X-original-commit: 57695f8
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants