Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX]stock_account: don't show consumable in valuation report #66062

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Feb 12, 2021

In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #65786
Forward-Port-Of: #65726

@robodoo
Copy link
Contributor

robodoo commented Feb 12, 2021

Pull request status dashboard

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Feb 12, 2021
@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 12, 2021

This PR targets saas-14.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 12, 2021

Ping @yhu-odoo, @amoyaux

ci/runbot failed on this forward-port PR

@C3POdoo C3POdoo added the RD research & development, internal work label Feb 12, 2021
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

X-original-commit: daee735
@yhu-odoo yhu-odoo force-pushed the saas-14.2-13.0-stock-valuation-no-consumable-yhu-dkON-fw branch from c20f3b0 to f509ca3 Compare February 16, 2021 08:56
@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 16, 2021

This PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

@amoyaux
Copy link
Contributor

amoyaux commented Feb 16, 2021

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 16, 2021
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

closes #66062

X-original-commit: daee735
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
@robodoo robodoo closed this Feb 16, 2021
@robodoo robodoo temporarily deployed to merge February 16, 2021 12:19 Inactive
@fw-bot fw-bot deleted the saas-14.2-13.0-stock-valuation-no-consumable-yhu-dkON-fw branch March 2, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants