Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change product type #62622

Closed
wants to merge 2 commits into from
Closed

Change product type #62622

wants to merge 2 commits into from

Conversation

nim-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Contributor

robodoo commented Nov 30, 2020 •
edited
Loading

Pull request status dashboard

@nim-odoo
Copy link
Contributor Author

robodoo rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Nov 30, 2020

Merge method set to rebase and fast-forward

amoyaux
amoyaux approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@amoyaux amoyaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add. "It's recommended to archive this product and create a new one". At the end of warning? Otherwise everything is good to me.

@nim-odoo
[IMP] stock: add warning on type change
4debd10 
Changing a product type from Consumable to Storable usually gives
unexpected results once some stock movements have been performed
(negative inventory, wrong valuation...).

While it should remain possible to do it (as long as the user knows what
he is doing), it is worth pointing the fact that unexpected results
are... to be expected.

To do so, we raise a non-blocking warning.
@nim-odoo
[FIX] stock_account, stock_landed_costs: do not create SVL for consum…
e658ef0 
…able

The creation of a Stock Valuation Layer is useless in case of a
Consumable product. At best it is useless, at worst it causes
inconsistencies when the user switch from a Consumable to a Storable
type.
@nim-odoo nim-odoo self-assigned this Nov 30, 2020
@nim-odoo
Copy link
Contributor Author

nim-odoo commented Dec 1, 2020

robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Dec 1, 2020

Staging failed: ci/template on cb90206067c0c3d45961e40dc2a4b5110c5ce2df (view more at http://runbot.odoo.com/runbot/build/5227906)

@d-fence
Copy link
Contributor

d-fence commented Dec 1, 2020

robodoo retry

robodoo pushed a commit that referenced this pull request Dec 1, 2020
@nim-odoo
[FIX] stock_account, stock_landed_costs: do not create SVL for consum…
2b3de65 
…able

The creation of a Stock Valuation Layer is useless in case of a
Consumable product. At best it is useless, at worst it causes
inconsistencies when the user switch from a Consumable to a Storable
type.

closes #62622

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo robodoo closed this Dec 1, 2020
@robodoo robodoo temporarily deployed to merge December 1, 2020 12:19 Inactive
@fw-bot fw-bot mentioned this pull request Dec 1, 2020
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Dec 5, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #62679

2 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Dec 6, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #62679

@fw-bot
Copy link
Contributor

fw-bot commented Dec 7, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #62679

@fw-bot fw-bot mentioned this pull request Dec 7, 2020
Closed
@fw-bot fw-bot deleted the 13.0-consu_storable-nim branch December 15, 2020 12:46
@yhu-odoo yhu-odoo mentioned this pull request Feb 8, 2021
Closed
yhu-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 8, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
6de9f08 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726
robodoo pushed a commit that referenced this pull request Feb 9, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
57695f8 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
@fw-bot fw-bot mentioned this pull request Feb 9, 2021
Closed
yhu-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
5b02f3a 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

X-original-commit: 57695f8
robodoo pushed a commit that referenced this pull request Feb 12, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
daee735 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

closes #65786

X-original-commit: 57695f8
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
12fa397 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

X-original-commit: daee735
@fw-bot fw-bot mentioned this pull request Feb 12, 2021
Closed
@fw-bot fw-bot mentioned this pull request Feb 12, 2021
Closed
yhu-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 16, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
f509ca3 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

X-original-commit: daee735
robodoo pushed a commit that referenced this pull request Feb 16, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
415a65f 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

closes #66062

X-original-commit: daee735
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
robodoo pushed a commit that referenced this pull request Feb 16, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
01bc7db 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

closes #66054

X-original-commit: daee735
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 16, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
612f691 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

X-original-commit: 415a65f
@fw-bot fw-bot mentioned this pull request Feb 16, 2021
Closed
robodoo pushed a commit that referenced this pull request Feb 16, 2021
@yhu-odoo
[FIX]stock_account: don't show consumable in valuation report
0e83fb5 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

closes #66260

X-original-commit: 415a65f
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Yuchen Huang <yhu-odoo@users.noreply.github.com>
@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Apr 23, 2021
Closed
fmdl pushed a commit to fmdl/odoo that referenced this pull request Apr 29, 2021
@yhu-odoo @fmdl
[FIX]stock_account: don't show consumable in valuation report
c4f2304 
In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in odoo#62622 which disabled svl for consumable products,
then rolled back in odoo#63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR odoo#65726

closes odoo#65786

X-original-commit: 57695f8
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoyaux amoyaux amoyaux approved these changes

Assignees

@nim-odoo nim-odoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nim-odoo @robodoo @d-fence @fw-bot @amoyaux