Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class in t-att doesn't benefit from class merging #1453

Closed
sdegueldre opened this issue Jun 8, 2023 · 1 comment
Closed

class in t-att doesn't benefit from class merging #1453

sdegueldre opened this issue Jun 8, 2023 · 1 comment

Comments

@sdegueldre
Copy link
Contributor

No description provided.

@rfr-odoo
Copy link
Contributor

rfr-odoo commented Jun 8, 2023

Playground exemple : 1

ged-odoo added a commit that referenced this issue Jun 19, 2023
@ged-odoo
[FIX] blockdom: properly merge dynamic class values
87a64ad 
Class attributes are managed in a specific way in owl: they are merged
with existing class attributes, and also, they can be defined in
multiple ways (t-att-class, t-attf-class, t-att=['class', ...] and each
of these can be combined together.

Before this commit, the `t-att` syntax was handled as a normal
attribute, and therefore, would not combine as required with existing
classes.

closes #1453
ged-odoo added a commit that referenced this issue Jun 19, 2023
@ged-odoo
[FIX] blockdom: properly merge dynamic class values
75e3cad 
Class attributes are managed in a specific way in owl: they are merged
with existing class attributes, and also, they can be defined in
multiple ways (t-att-class, t-attf-class, t-att=['class', ...] and each
of these can be combined together.

Before this commit, the `t-att` syntax was handled as a normal
attribute, and therefore, would not combine as required with existing
classes.

closes #1453
phil-form pushed a commit to phil-form/owl that referenced this issue Nov 7, 2023
@ged-odoo @phil-form
[FIX] blockdom: properly merge dynamic class values
55d4882 
Class attributes are managed in a specific way in owl: they are merged
with existing class attributes, and also, they can be defined in
multiple ways (t-att-class, t-attf-class, t-att=['class', ...] and each
of these can be combined together.

Before this commit, the `t-att` syntax was handled as a normal
attribute, and therefore, would not combine as required with existing
classes.

closes odoo#1453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdegueldre @rfr-odoo