Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] slots: make defaultContent of slot available to slot as zero #1314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdegueldre
Copy link
Contributor

In some cases, it is useful for a slot to be able to keep the default content of the slot it is supposed to replace and simply add extra content instead of simply replacing it entirely. This commit makes the default content of a slot available in the context as zero similar to how t-call can access the content that was inside the t-call.

In some cases, it is useful for a slot to be able to keep the default
content of the slot it is supposed to replace and simply add extra
content instead of simply replacing it entirely. This commit makes the
default content of a slot available in the context as `zero` similar to
how t-call can access the content that was inside the t-call.
Copy link
Contributor

@ged-odoo ged-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks weirdly elegant. I feel unsure that this is what we want, but it makes sense. also, if we do this, the doc should be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants