[FIX] extensions: guarantee to call transitionend callback #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a possibility that the transitionend event of an element/component with t-transition directive won't trigger. Though this situation is difficult to assert, it was observe in odoo runbot for the pos ui. When the transitionend event is not fired, the callback that removes the element from the dom won't be called, resulting to a corrupted view. An example of which is the following: ```html <div t-if="show" t-transition="fade">Hello</div> ``` If `show` is set to false by some ui action and by any chance the transitionend event is not fired (perhaps because the transition didn't actually start or because of completely unknown reason), the div element will remain in the view -- and this is not desirable. This commit patches this situation such that if after 50ms that the transitionend event is supposed to be fired but the event isn't fired, we force the callback using a setTimeout. This guarantees the call of the callback that is suppose to remove the element from the view.
caburj
force-pushed
the
patch-transitionend-jcb
branch
from
96fd249
to
c9ade6c
Compare
|
I only took the commit with the setTimeout and merged it in PR #891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility that the transitionend event of an element/component
with t-transition directive won't trigger. Though this situation is
difficult to assert, it was observe in odoo runbot for the pos ui.
When the transitionend event is not fired, the callback that removes
the element from the dom won't be called, resulting to a corrupted view.
An example of which is the following:
If
showis set to false by some ui action and by any chance thetransitionend event is not fired (perhaps because the transition didn't
actually start or because of completely unknown reason), the div element
will remain in the view -- and this is not desirable.
This commit patches this situation such that if after 50ms that the
transitionend event is supposed to be fired but the event isn't fired, we
force the callback using a setTimeout. This guarantees the call of the
callback that is suppose to remove the element from the view.