chore: improve code coverage #350
Conversation
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestDiscoverPlugins(t *testing.T) { |
There was a problem hiding this comment.
@mabdh I need some context arounf plugins/external directory, around its usecase, and requirements. Anything in docs/previous-PR/issue/discussion??
There was a problem hiding this comment.
@GrayFlash I don't really aware of the docs about it, maybe @ravisuhag or @StewartJingga has more context with that.
| @@ -1,3 +1,6 @@ | |||
| //go:build plugins | |||
| // +build plugins | |||
|
|
|||
There was a problem hiding this comment.
Added plugins tags for tableau and bigquery tests, because we test extractors separately.
cc @mabdh
|
@mabdh @StewartJingga @scortier any suggestions for further improving the code coverage?? Most of the files with low coverage that I can see at the moment are the ones where we can't test a given set of functions with mocks or may require setting up a service (like bigquery, tableau, etc). |
|
@GrayFlash this is already good enough to have 75 % code coverage. Have you seen the coverage report here? https://coveralls.io/github/odpf/meteor?branch=improve-code-coverage for example:
|
|
@mabdh have worked on increasing the coverage across the |
closes #348