Rm dead code, re:#63 #673
Merged
Rm dead code, re:#63 #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 27.26% 27.27%
=======================================
Files 7 7
Lines 1247 1243 -4
Branches 191 190 -1
=======================================
- Hits 340 339 -1
+ Misses 882 879 -3
Partials 25 25
Continue to review full report at Codecov.
|
machawk1
added a commit
that referenced
this pull request
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In investigating how coupled we are with reading and writing the ipwb config to the IPFS config file, I found that this function is never called.
@ibnesayeed If I recall, you wanted this interaction with the config file to be removed, correct? If so, #63 might be moot and instead, there should be an issue to remove it (i.e., #349).