App refactoring #89
Merged
App refactoring #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gregdel
commented
Jan 6, 2016
gregdel
commented
- Move the app parts in internal packages and sub applications
- Use log entries everywhere
- handle sighup events to reload the app
- graceful shutdown of all the sub applications
gregdel
force-pushed
the
appRefactoring
branch
from
0b72658
to
b262be0
Compare
gregdel
changed the title
|
+1 |
|
Try to fix the fake increase of coverage before merge this |
gregdel
force-pushed
the
appRefactoring
branch
from
b262be0
to
18ec41b
Compare
gregdel
changed the title
gregdel
force-pushed
the
appRefactoring
branch
3 times, most recently
from
56a4a55
to
ece070d
Compare
|
|
||
| a.startApps(log) | ||
|
|
||
| log.Info("app reloaded") |
There was a problem hiding this comment.
the main app
see here for the subapps: https://github.com/odwrtw/polochon/blob/appRefactoring/app/internal/app/app.go#L213
gregdel
force-pushed
the
appRefactoring
branch
3 times, most recently
from
fc4c4b1
to
450bad7
Compare
* Use log entries everywhere
* Handle app reload with SIGHUP
* Move all the apps into sub apps
* Each sub app is launched by the main app
* Available sub apps:
* http server
* organizer
* downloader
* cleaner
gregdel
force-pushed
the
appRefactoring
branch
from
450bad7
to
22b66ff
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.