redesign profile page #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhS78
requested changes
Dec 8, 2022
frontend/components/Issues.jsx
Outdated
| @@ -11,7 +11,7 @@ const Issue = ({ Card }) => { | |||
| > | |||
| <h4> | |||
| <b> | |||
| {Card.repoName} - {Card.tag} | |||
| //{Card.repoName} - {Card.tag} | |||
There was a problem hiding this comment.
Why did we hardcode this?
frontend/components/Profile.jsx
Outdated
| @@ -67,16 +61,21 @@ const Profile = ({ uname, aname, role, eno, contact, email, pfp }) => { | |||
| }} | |||
| /> | |||
| </div> | |||
| )} | |||
| )} */} | |||
There was a problem hiding this comment.
remove unused (commented) code
frontend/components/Profile.jsx
Outdated
Comment on lines
69
to
73
| {editProfile === true ? ( | ||
| <label className="role">{role}</label> | ||
| ) : ( | ||
| true | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {editProfile === true ? ( | |
| <label className="role">{role}</label> | |
| ) : ( | |
| true | |
| )} | |
| {editProfile === true && ( | |
| <label className="role">{role}</label> | |
| )} |
frontend/components/Profile.jsx
Outdated
| true | ||
| )} | ||
| </div> | ||
| {editProfile } |
frontend/components/Profile.jsx
Outdated
| <label className="details">{uname}</label> | ||
| </div> | ||
| <div className="rankHandle"> | ||
| <label className="userHandle">()</label> |
There was a problem hiding this comment.
Why are these values hardcoded as empty?
frontend/components/Profile.jsx
Outdated
| </div> | ||
| <div className="rankHandle"> | ||
| <label className="userHandle">()</label> | ||
| <label className="userHandle">#RANK</label> |
frontend/components/PullRequests.jsx
Outdated
Comment on lines
3
to
22
| const Issue = ({ Card }) => { | ||
| return ( | ||
| <div className="pullbox"> | ||
| <div | ||
| style={{ | ||
| textAlign: "center", | ||
| margin: "1rem", | ||
| }} | ||
| > | ||
| <h4> | ||
| <b> | ||
|
|
||
| </b> | ||
| </h4> | ||
|
|
||
| </div> | ||
| <div className="mentora"></div> | ||
| </div> | ||
| ); | ||
| }; |
Comment on lines
26
to
27
| // top: -10rem; | ||
| // left: 1rem; |
frontend/styles/modules/Profile.scss
Outdated
| .image { | ||
| } | ||
| .image { | ||
| position: relative; | ||
| left: 5%; | ||
| top: 2%; | ||
| //margin-left: 5%; |
frey0-0
force-pushed
the
redesign-profile
branch
from
7ae9999
to
31bc0c6
Compare
SaurabhS78
reviewed
Dec 10, 2022
frontend/components/PendingList.jsx
Outdated
| const PendingList= ({ list, callback }) => { | ||
| return ( | ||
| list.map((Card, i) => { | ||
| return <PendingCard Card={Card} key={i} callback={callback} />; |
There was a problem hiding this comment.
Why are we passing callback prop?
There was a problem hiding this comment.
Also props are incorrect
frontend/components/MergedList.jsx
Outdated
| const MergedList= ({ list, callback }) => { | ||
| return ( | ||
| list.map((Card, i) => { | ||
| return <MergedCard Card={Card} key={i} callback={callback} />; |
frontend/components/PullRequests.jsx
Outdated
| </h4> | ||
|
|
||
| </div> | ||
| <div className="mentora"></div> |
frontend/pages/profile/index.jsx
Outdated
Comment on lines
59
to
67
| const issues = response.data.assignedIssues; | ||
| let repos = []; | ||
| if (issues != undefined || issues != null) | ||
| issues.forEach(async (element) => { | ||
| var repoInfo = element.issue.split("/"); | ||
| repos = JSON.parse(JSON.stringify(repos)); | ||
| repos.push({ | ||
| }); | ||
| setPending(JSON.parse(JSON.stringify(repos))); |
There was a problem hiding this comment.
backend only sends one issue. Assigned issue can only be one at a time. Also property is incorrect. Use response.data.user.assignedIssue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.