Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exported module name #20

Closed
wants to merge 1 commit into from

Conversation

broerjuang
Copy link

Change the module export name to loader, action, and ErrorBoundary to match with Remix convention.

@oedotme
Copy link
Owner

oedotme commented Nov 28, 2022

Thanks for the update, it was the case initially having them lowercased loader, action but there was an issue with Vite's HMR that causes issues while updating those functions, here's the related issue #5

The new HMR implementation that will make it work while lowercased is still experimental afaik, but hopefully soon we can have it back. Also I think as we're using React Router, it makes more sense to follow its route definition API:

image

So we'd then go with loader, action and ErrorElement (same but w/ first letter capitalized as it's a React component)

@oedotme
Copy link
Owner

oedotme commented Dec 9, 2022

Now we have the core exported, you can rename the exports and update the module types using a custom integration if you still need that, #28 is a related issue that has a usage example.

@oedotme oedotme closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants