Add fuel cell draft code #329
Conversation
|
Hello @matbock! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-08-14 09:10:28 UTC |
|
This pull request introduces 5 alerts when merging 1600d09 into 26865e3 - view on LGTM.com new alerts:
|
| hf['H2O'] = -286000 | ||
| hf['H2'] = 0 | ||
| hf['O2'] = 0 | ||
| M = molar_masses['H2'] |
There was a problem hiding this comment.
Can you modify this line to make it not hard coded, like here: https://github.com/BenPortner/tespy/blob/91327482880a6494afcb0ea7d2c9cc3501b443f0/src/tespy/components/reactors/water_electrolyzer.py#L312
|
@matbock: I added some ToDos as comments in the code, could you have a look at them? Thanks! |
| 0 = x_\mathrm{i,in,1} - x_\mathrm{i,out,1} | ||
| \forall i \in \text{network fluids} | ||
| 0 = \begin{cases} | ||
| 1 - x_\mathrm{i,in2} & \text{i=}H_{2}O\\ | ||
| x_\mathrm{i,in2} & \text{else} | ||
| \end{cases} \forall i \in \text{network fluids} | ||
| 0 = \begin{cases} | ||
| 1 - x_\mathrm{i,out,2} & \text{i=}O_{2}\\ | ||
| x_\mathrm{i,out,2} & \text{else} | ||
| \end{cases} \forall i \in \text{network fluids} | ||
| 0 = \begin{cases} | ||
| 1 - x_\mathrm{i,out,3} & \text{i=}H_{2}\\ | ||
| x_\mathrm{i,out,3} & \text{else} | ||
| \end{cases} \forall i \in \text{network fluids} |
There was a problem hiding this comment.
There are some linebreaks missing here:
The code implements a fuel cell as new component. It is designed just like the water electrolyzer, i.e. it produces water out of hydrogen and oxygen with an additional cooling fluid.
The import of the code is implemented in the components init file, the code itself is located in the folder components/reactors.