Update required flag in form labels on attribute change

oetiker · Feb 27, 2024 · 6e3caec · 6e3caec
1 parent f52e8cf
commit 6e3caec
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,5 @@
+ - Update required flag on change of required property
+
 0.49.2 2024-02-20 09:57:55 +0100 Tobias Oetiker <tobi@oetiker.ch>
 
  - Add command `showconfig` to show config documentation form Config.pm

diff --git a/lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/form/renderer/NoteForm.js b/lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/form/renderer/NoteForm.js
@@ -139,15 +139,21 @@ qx.Class.define("callbackery.ui.form.renderer.NoteForm", {
             // add the items
             var msg = callbackery.ui.MsgBox.getInstance();
             var that = this;
-            for (var i = 0; i < items.length; i++) {
+            for (let i = 0; i < items.length; i++) {
                 (function () { // context
                     let label = that._createLabel(names[i], items[i]);
                     let item = items[i];
                     item.set({
                         marginTop: 2,
                         marginBottom: 2
                     });
-                    var labelName = names[i];
+                    let labelName = names[i];
+
+                    // rerender form to update required flag
+                    item.addListener("changeRequired", (e) => {
+                        that._onChangeLocale(e);
+                    }, that);
+
                     // allow form items without label
                     if (label) {
 
@@ -183,6 +189,7 @@ qx.Class.define("callbackery.ui.form.renderer.NoteForm", {
                         });
                     }
                     that._add(item, { row: that._row + 1, column: 1 });
+
                     if (itemOptions != null && itemOptions[i] != null) {
                         if (itemOptions[i].note) {
                             that._gotNote = true;